Update FV3 hash :: Removes all GNU compile warnings#1095
Merged
DusanJovic-NOAA merged 6 commits intoNOAA-EMC:developfrom Apr 24, 2026
Merged
Update FV3 hash :: Removes all GNU compile warnings#1095DusanJovic-NOAA merged 6 commits intoNOAA-EMC:developfrom
DusanJovic-NOAA merged 6 commits intoNOAA-EMC:developfrom
Conversation
21 tasks
DusanJovic-NOAA
approved these changes
Apr 17, 2026
BrianCurtis-NOAA
approved these changes
Apr 17, 2026
Collaborator
Collaborator
Author
|
Hash updated and gitmodules file reverted. Should be good to merge. |
Collaborator
|
@DusanJovic-NOAA This PR is ready to merge. :) Testing completed successfully on ufs-community/ufs-weather-model#3196 . |
DeniseWorthen
pushed a commit
to DeniseWorthen/ufsatm
that referenced
this pull request
Apr 27, 2026
Update the atmos_cubed model hash to bring in changes that resolve warnings that are triggered by the GNU compiler. The warnings were a result from trailing text after a handful of #if and #endif statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will update the atmos_cubed model hash to bring in changes that resolve warnings that are triggered by the GNU compiler. The warnings were a result from trailing text after a handful of
#ifand#endifstatements.Issue(s) addressed
Testing
These changes were tested on Ursa using the UFS WM regression test suite.
Dependencies