Skip to content

Fix GNU compiler warnings#412

Merged
vithikashah001 merged 2 commits intoNOAA-GFDL:dev/emcfrom
dpsarmie:fix/gnu_compiler_warnings
Apr 24, 2026
Merged

Fix GNU compiler warnings#412
vithikashah001 merged 2 commits intoNOAA-GFDL:dev/emcfrom
dpsarmie:fix/gnu_compiler_warnings

Conversation

@dpsarmie
Copy link
Copy Markdown

Description
This PR will bring in changes that will fix the compiler warning bugs that were occurring with the GNU compiler. The warnings were all of the same type. Comments have been added above the #if or #endif statements that previously had trailing text.

The comment format can be changed, but I'll leave that up to the CMs.

Fixes #411

How Has This Been Tested?
These changes were testing using the UFS Weather Model regression test system. No baseline changes were generated.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JosephMouallem
Copy link
Copy Markdown
Contributor

Looks good to me, thanks.

@gspetro-NOAA
Copy link
Copy Markdown

This PR can be merged. Testing completed successfully for ufs-community/ufs-weather-model#3196.

@gspetro-NOAA
Copy link
Copy Markdown

@vithikashah001 Could you merge this PR?

@vithikashah001 vithikashah001 merged commit ecb6c48 into NOAA-GFDL:dev/emc Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants