SCAL-274111 Add hideTagFilterChips option to AppEmbed for cleaner UI #324

shivam-kumar-ts · 2025-10-06T09:04:44Z

Add hideTagFilterChips option to AppEmbed for cleaner UI

mnk-blr · 2025-10-06T09:04:56Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

gemini-code-assist · 2025-10-06T09:05:00Z

Summary of Changes

Hello @shivam-kumar-ts, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new hideTagFilterChips option within the BaseViewConfig to provide a cleaner user interface. This configuration flag, when enabled, automatically manages the visibility of tag-related UI components, such as filter chips, the 'Manage Tags' action, and the 'Tags' column in list pages, thereby simplifying the process of customizing the display for embedded applications.

Highlights

New Configuration Option: Introduced a new hideTagFilterChips boolean option to the BaseViewConfig interface, allowing for simplified control over tag-related UI elements.
Automated UI Cleanup: When hideTagFilterChips is set to true, the system automatically ensures that tag filter indicators/chips are hidden, Action.ManageTags is added to hiddenActions, and ListPageColumns.Tags is added to hiddenListColumns.
Simplified Tag Management: This feature provides a single, convenient flag to streamline the user interface by removing various tag-related elements without requiring manual configuration of individual hiddenActions or hiddenListColumns.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new hideTagFilterChips option to BaseViewConfig, which simplifies hiding tag-related UI elements by automatically managing hiddenListColumns and hiddenActions. The implementation is functionally correct. My feedback focuses on improving code conciseness and maintainability by refactoring duplicated logic and fixing a minor formatting issue in the JSDoc.

gemini-code-assist · 2025-10-06T09:06:22Z

src/embed/ts-embed.ts

+        const finalHiddenListColumns = [...(this.viewConfig.hiddenListColumns || [])];
+        if (this.viewConfig.hideTagFilterChips) {
+            if (!finalHiddenListColumns.includes(ListPageColumns.Tags)) {
+                finalHiddenListColumns.push(ListPageColumns.Tags);
+            }
+        }


This block of code can be made more concise by using a Set to handle the uniqueness of elements, and conditional spreading to add the new tag. This approach is cleaner and avoids nested if statements. A similar pattern can be applied to the logic for finalHiddenActions as well to reduce code duplication.

const finalHiddenListColumns = [...new Set([ ...(this.viewConfig.hiddenListColumns || []), ...(this.viewConfig.hideTagFilterChips ? [ListPageColumns.Tags] : []), ])];

gemini-code-assist · 2025-10-06T09:06:22Z

src/embed/ts-embed.ts

+        const finalHiddenActions = [...(hiddenActions ?? [])];
+        if (hideTagFilterChips) {
+            if (!finalHiddenActions.includes(Action.ManageTags)) {
+                finalHiddenActions.push(Action.ManageTags);
+            }
+        }


Similar to the logic for hiddenListColumns, this block can be simplified. Using a Set with conditional spreading provides a more concise and readable way to ensure Action.ManageTags is added to the hiddenActions array without duplicates.

const finalHiddenActions = [...new Set([ ...(hiddenActions ?? []), ...(hideTagFilterChips ? [Action.ManageTags] : []), ])];

gemini-code-assist · 2025-10-06T09:06:22Z

src/types.ts

+        /**
+     * Hide tag filter chips that appear when content is filtered by tags.
+     * When enabled, this automatically:
+     * - Hides tag filter indicators/chips from the UI
+     * - Adds Action.ManageTags to hiddenActions (if not already present)
+     * - Adds ListPageColumns.Tags to hiddenListColumns (if not already present)
+     * 
+     * This provides a clean interface without tag-related UI elements.
+     *
+     * Supported embed types: `AppEmbed`
+     * @version SDK: 1.42.1 | ThoughtSpot: 10.14.0.cl
+     * @example
+     * ```js
+     * // Simple usage - automatically hides all tag-related UI
+     * const embed = new AppEmbed('#tsEmbed', {
+     *    ... // other embed view config
+     *    tag: 'Retail Sales',
+     *    hideTagFilterChips: true, // This is all you need!
+     * });
+     * 
+     * // No need to manually specify:
+     * // hiddenActions: [Action.ManageTags],
+     * // hiddenListColumns: [ListPageColumns.Tags]
+     * ```
+     */


The JSDoc for the new hideTagFilterChips property is indented incorrectly. It should be aligned with the other properties in the BaseViewConfig interface for consistency.

/** * Hide tag filter chips that appear when content is filtered by tags. * When enabled, this automatically: * - Hides tag filter indicators/chips from the UI * - Adds Action.ManageTags to hiddenActions (if not already present) * - Adds ListPageColumns.Tags to hiddenListColumns (if not already present) * * This provides a clean interface without tag-related UI elements. * * Supported embed types: `AppEmbed` * @version SDK: 1.42.1 | ThoughtSpot: 10.14.0.cl * @example * ```js * // Simple usage - automatically hides all tag-related UI * const embed = new AppEmbed('#tsEmbed', { * ... // other embed view config * tag: 'Retail Sales', * hideTagFilterChips: true, // This is all you need! * }); * * // No need to manually specify: * // hiddenActions: [Action.ManageTags], * // hiddenListColumns: [ListPageColumns.Tags] * ``` */

pkg-pr-new · 2025-10-06T09:06:49Z

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@324

commit: 0142412

utsavkapoor · 2025-10-06T17:21:19Z

src/embed/app.ts

+     * This provides a clean interface without tag-related UI elements.
+     *
+     * Supported embed types: `AppEmbed`
+     * @version SDK: 1.42.1 | ThoughtSpot: 10.14.0.cl


Thoughtspot version would be 10.15.0.cl

adityamittal3107 · 2025-10-07T11:38:26Z

src/embed/app.ts

+     * This provides a clean interface without tag-related UI elements.
+     *
+     * Supported embed types: `AppEmbed`
+     * @version SDK: 1.42.1 | ThoughtSpot: 10.15.0.cl


SDK version is incorrect.
Shivam while writing the SDK version, map SDK version like this -
For 10.13.0.cl, we will be having 1.42.0
For 10.14.0.cl, we will be having 1.43.0
So for 10.15.0.cl, we will be having 1.44.0 as the SDK version. And if the changes are only in SDK, then add SDK version as next minor version for example - 1.42.1 is already published so next minor version is 1.42.2 so add that as the SDK version and then publish the new version

adityamittal3107 · 2025-10-07T15:15:53Z

src/embed/app.ts

+     * This provides a clean interface without tag-related UI elements.
+     *
+     * Supported embed types: `AppEmbed`
+     * @version SDK: 1.42.2 | ThoughtSpot: 10.15.0.cl


SDK version will be 1.44.0

adityamittal3107 · 2025-10-07T15:16:08Z

src/embed/app.ts

+     *    hideTagFilterChips: true, // This is all you need!
+     * });
+     * 
+     * // No need to manually specify:


No need to mention this

adityamittal3107 · 2025-10-07T15:16:32Z

src/embed/app.ts

+     * Hide tag filter chips that appear when content is filtered by tags.
+     * When enabled, this automatically:
+     * - Hides tag filter indicators/chips from the UI
+     * - Adds Action.ManageTags to hiddenActions (if not already present)


We are not doing this right? why have we added this?

this AppViewConfig will do this things, so added as a reference for the user

adityamittal3107 · 2025-10-08T12:48:29Z

src/embed/app.ts

        params[Param.IsUnifiedSearchExperienceEnabled] = isUnifiedSearchExperienceEnabled;
        params[Param.CoverAndFilterOptionInPDF] = !!coverAndFilterOptionInPDF;
        params[Param.LiveboardXLSXCSVDownload] = !!liveboardXLSXCSVDownload;
+        params[Param.HideTagFilterChips] = hideTagFilterChips;


Let's not add it by default. It will unnecessary increase the length of the url. Check if it is not undefined then only add it as part of query params. Look at other places how we have added query params optionally.

…meter handling in AppEmbed

sonar-prod-ts · 2025-10-10T14:30:17Z

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

shivam-kumar-ts requested a review from a team as a code owner October 6, 2025 09:04

gemini-code-assist bot reviewed Oct 6, 2025

View reviewed changes

shivam-kumar-ts force-pushed the SCAL-274111 branch 2 times, most recently from 42356c3 to aeeb08d Compare October 6, 2025 11:57

shivam-kumar-ts changed the title ~~SCAL-274111 Add hideTagFilterChips option to BaseViewConfig for cleaner UI~~ SCAL-274111 Add hideTagFilterChips option to AppEmbed for cleaner UI Oct 6, 2025

shivam-kumar-ts force-pushed the SCAL-274111 branch 3 times, most recently from af5068a to 183ef0c Compare October 6, 2025 12:10

utsavkapoor reviewed Oct 6, 2025

View reviewed changes

adityamittal3107 reviewed Oct 7, 2025

View reviewed changes

shivam-kumar-ts force-pushed the SCAL-274111 branch from c7b53ea to 46fdf79 Compare October 7, 2025 11:52

adityamittal3107 reviewed Oct 7, 2025

View reviewed changes

shivam-kumar-ts force-pushed the SCAL-274111 branch 2 times, most recently from d5fa94a to ec7c7fb Compare October 8, 2025 10:59

adityamittal3107 reviewed Oct 8, 2025

View reviewed changes

shivam-kumar-ts force-pushed the SCAL-274111 branch from e98108a to 6226a26 Compare October 8, 2025 12:57

shivam-kumar-ts added 4 commits October 10, 2025 11:49

SCAL-274111 Added hideTagFilterChips option to AppEmbed

59fef02

SCAL-274111 updated version

54a8534

SCAL-274111 Refactor documentation

d392a2b

SCAL-274111 Add test for undefined hideTagFilterChips and update para…

29be9ad

…meter handling in AppEmbed

shivam-kumar-ts force-pushed the SCAL-274111 branch 2 times, most recently from 393f415 to 75ede10 Compare October 10, 2025 06:31

adityamittal3107 approved these changes Oct 10, 2025

View reviewed changes

SCAL-274111 Update typedoc.json

0142412

shivam-kumar-ts force-pushed the SCAL-274111 branch from 75ede10 to 0142412 Compare October 10, 2025 14:29

shivam-kumar-ts merged commit ecc671e into main Oct 10, 2025
9 of 10 checks passed

SCAL-274111 Add hideTagFilterChips option to AppEmbed for cleaner UI #324

SCAL-274111 Add hideTagFilterChips option to AppEmbed for cleaner UI #324

Uh oh!

Conversation

shivam-kumar-ts commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mnk-blr commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

gemini-code-assist bot commented Oct 6, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonar-prod-ts bot commented Oct 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shivam-kumar-ts commented Oct 6, 2025 •

edited

Loading

mnk-blr commented Oct 6, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 6, 2025 •

edited

Loading