SCAL-274111 added test for hideTagFilterChips

Author: shivam-kumar-ts

src/embed/ts-embed.spec.ts

@@ -28,6 +28,7 @@ import {
     ContextMenuTriggerOptions,
     CustomActionTarget,
     CustomActionsPosition,
+    ListPageColumns,
 } from '../types';
 import {
     executeAfterWait,
@@ -3456,4 +3457,74 @@ describe('Unit test case for ts embed', () => {
             triggerSpy.mockReset();
         });
     });
+
+    describe('hideTagFilterChips functionality', () => {
+        beforeAll(() => {
+            init({
+                thoughtSpotHost: 'tshost',
+                authType: AuthType.None,
+            });
+        });
+        test('when hideTagFilterChips is true should automatically add Action.ManageTags to hiddenActions for AppEmbed', async () => {
+            const appEmbed = new AppEmbed(getRootEl(), {
+                frameParams: {
+                    width: '100%',
+                    height: '100%',
+                },
+                hideTagFilterChips: true,
+            });
+            appEmbed.render();
+            await waitFor(() => !!getIFrameEl()).then(() => {
+                const iframeSrc = getIFrameSrc();
+                expect(iframeSrc).toContain(encodeURIComponent(`"${Action.ManageTags}"`));
+                expect(iframeSrc).toContain('hideAction=');
+            });
+        });
+
+        test('when hideTagFilterChips is false should not add Action.ManageTags to hiddenActions for AppEmbed', async () => {
+            const appEmbed = new AppEmbed(getRootEl(), {
+                frameParams: {
+                    width: '100%',
+                    height: '100%',
+                },
+            });
+            appEmbed.render();
+            await waitFor(() => !!getIFrameEl()).then(() => {
+                const iframeSrc = getIFrameSrc();
+                expect(iframeSrc).not.toContain(encodeURIComponent(`"${Action.ManageTags}"`));
+                expect(iframeSrc).toContain('hideAction=');
+            });
+        });
+
+        test('should work with existing hiddenListColumns without duplicates', async () => {
+            const appEmbed = new AppEmbed(getRootEl(), {
+                ...defaultViewConfig,
+                hideTagFilterChips: true,
+                hiddenListColumns: [ListPageColumns.Author, ListPageColumns.Favourite],
+            } as AppViewConfig);
+
+            const appInitData = await (appEmbed as any).getDefaultAppInitData();
+            
+            expect(appInitData.hiddenListColumns).toContain(ListPageColumns.Author);
+            expect(appInitData.hiddenListColumns).toContain(ListPageColumns.Favourite);
+            expect(appInitData.hiddenListColumns).toContain(ListPageColumns.Tags);
+            
+            const tagsCount = appInitData.hiddenListColumns.filter(
+                (col: ListPageColumns) => col === ListPageColumns.Tags
+            ).length;
+            expect(tagsCount).toBe(1);
+        });
+
+        test('should not automatically add ListPageColumns.Tags to hiddenListColumns', async () => {
+            const appEmbed = new AppEmbed(getRootEl(), {
+                ...defaultViewConfig,
+                hideTagFilterChips: false,
+            } as AppViewConfig);
+
+            const appInitData = await (appEmbed as any).getDefaultAppInitData();
+            
+            expect(appInitData.hiddenListColumns).not.toContain(ListPageColumns.Tags);
+            expect(appInitData.hiddenListColumns).toEqual([]);
+        });
+    });
 });

src/embed/ts-embed.ts

@@ -427,12 +427,10 @@ export class TsEmbed {
                 message: customActionsResult.errors,
             });
         }
-        const finalHiddenListColumns = [...(this.viewConfig.hiddenListColumns || [])];
-        if (this.viewConfig.hideTagFilterChips) {
-            if (!finalHiddenListColumns.includes(ListPageColumns.Tags)) {
-                finalHiddenListColumns.push(ListPageColumns.Tags);
-            }
-        }
+        const finalHiddenListColumns = [...new Set([
+            ...(this.viewConfig.hiddenListColumns || []),
+            ...(this.viewConfig.hideTagFilterChips ? [ListPageColumns.Tags] : []),
+        ])];
         return {
             customisations: getCustomisations(this.embedConfig, this.viewConfig),
             authToken,
@@ -662,12 +660,10 @@ export class TsEmbed {
         if (exposeTranslationIDs) {
             queryParams[Param.ExposeTranslationIDs] = exposeTranslationIDs;
         }
-        const finalHiddenActions = [...(hiddenActions ?? [])];
-        if (hideTagFilterChips) {
-            if (!finalHiddenActions.includes(Action.ManageTags)) {
-                finalHiddenActions.push(Action.ManageTags);
-            }
-        }
+        const finalHiddenActions = [...new Set([
+            ...(hiddenActions ?? []),
+            ...(hideTagFilterChips ? [Action.ManageTags] : []),
+        ])];
         queryParams[Param.HideActions] = [...this.defaultHiddenActions, ...finalHiddenActions];
         if (Array.isArray(visibleActions)) {
             queryParams[Param.VisibleActions] = visibleActions;

src/types.ts

@@ -1084,7 +1084,7 @@ export interface BaseViewConfig {
      * ```
      */
     customActions?: CustomAction[];
-        /**
+    /**
      * Hide tag filter chips that appear when content is filtered by tags.
      * When enabled, this automatically:
      * - Hides tag filter indicators/chips from the UI