SCAL-274111 Add test for undefined hideTagFilterChips and update parameter handling in AppEmbed

Author: shivam-kumar-ts

src/embed/app.spec.ts

@@ -433,6 +433,20 @@ describe('App embed tests', () => {
         });
     });
 
+    test('Should not add hideTagFilterChips if it is undefined', async () => {
+        const appEmbed = new AppEmbed(getRootEl(), {
+            ...defaultViewConfig,
+            showPrimaryNavbar: false,
+        } as AppViewConfig);
+        appEmbed.render();
+        await executeAfterWait(() => {
+            expectUrlMatchesWithParams(
+                getIFrameSrc(),
+                `http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false${defaultParams}${defaultParamsPost}#/home`,
+            );
+        });
+    });
+
     test('Should add enableSearchAssist flagto the iframe src', async () => {
         const appEmbed = new AppEmbed(getRootEl(), {
             ...defaultViewConfig,

src/embed/app.ts

@@ -703,7 +703,6 @@ export class AppEmbed extends V1Embed {
         params[Param.IsUnifiedSearchExperienceEnabled] = isUnifiedSearchExperienceEnabled;
         params[Param.CoverAndFilterOptionInPDF] = !!coverAndFilterOptionInPDF;
         params[Param.LiveboardXLSXCSVDownload] = !!liveboardXLSXCSVDownload;
-        params[Param.HideTagFilterChips] = hideTagFilterChips;
 
         params = this.getBaseQueryParams(params);
 
@@ -771,6 +770,10 @@ export class AppEmbed extends V1Embed {
         if (isPNGInScheduledEmailsEnabled !== undefined) {
             params[Param.isPNGInScheduledEmailsEnabled] = isPNGInScheduledEmailsEnabled;
         }
+        
+        if (hideTagFilterChips !== undefined) {
+            params[Param.HideTagFilterChips] = hideTagFilterChips;
+        }
 
         params[Param.DataPanelV2Enabled] = dataPanelV2;
         params[Param.HideHomepageLeftNav] = hideHomepageLeftNav;

static/typedoc/typedoc.json

@@ -11914,7 +11914,7 @@
 					"sources": [
 						{
 							"fileName": "embed/app.ts",
-							"line": 990,
+							"line": 993,
 							"character": 11
 						}
 					],
@@ -12031,7 +12031,7 @@
 					"sources": [
 						{
 							"fileName": "embed/app.ts",
-							"line": 859,
+							"line": 862,
 							"character": 11
 						}
 					],
@@ -12368,7 +12368,7 @@
 					"sources": [
 						{
 							"fileName": "embed/app.ts",
-							"line": 964,
+							"line": 967,
 							"character": 11
 						}
 					],
@@ -12744,7 +12744,7 @@
 					"sources": [
 						{
 							"fileName": "embed/app.ts",
-							"line": 1019,
+							"line": 1022,
 							"character": 17
 						}
 					],