Add OpenVox support

[bastelfreak]

This adds a fact that discovers if the Perforce or OpenVox agent is installed. If none are installed yet, we default to the Perforce package for backwards compatibility.

[bastelfreak]

This is a resubmission of #933. I pasically added pick() to handle situations where the fact is undef.

[charlesc-profusion]

This doesn't work on Openvox 7:

[binford2k]

ah yeah, we didn't backport that to 7.x. We probably should. Lemme chat with the team.

[Stricken1670]

EDIT: found it!

So I just installed this module and it's active, and I applied the https://github.com/theforeman/puppet-puppet/pull/935.diff for this PR and now I can install openvox with:

  if $facts['networking']['hostname'] == 'labrat' {
    class {
      'puppet':
        runmode => 'cron',
        client_package => 'openvox-agent',
        agent_server_hostname => 'theforeman.example.com',
    }
  }

Although it doesn't set up the repo yet.

[markeganfuller]

I think it's also required that terminus_package is set to openvoxdb-termini on puppetdb::master::config in puppet::server::puppetdb.

[ekohl]

Can we make it reflect that OpenVox introduced an implementation fact?

[sbernhard]

@bastelfreak Any plans to continue this? (looks like there are conflicts as #936 was already merged)

[sbernhard]

@bastelfreak The failling tests are not related to this change. Am I right? What do we need to merge this then? How can we help?

[bastelfreak]

@sbernhard

• as a first step, Drop puppet 7 support #955 should be merged to remove the broken puppet 7 integration (and before that maybe do a minor release).
• I pulled some cleanups into Cleanup leftovers for Debian without systemd #964
• and fixed docs in puppet::server::puppetdb & puppet::server::puppetserver: Fix puppet-strings documentation #965

[evgeni]

ewww. (no, I am not sure I can come with something more elegant, but wanted to express my eww here ;) )

[evgeni]

Hmm.

$puppetserver_flavor = bool2str($puppet_flavor == 'openvox', 'openvox-server', 'puppetserver')

Yes, this "breaks" any other flavor besides puppet and openvox, but… do we care?

[evgeni]

This is not true for the terminus_package, right? So why is it here? Did you want to say "This module works with both Puppet and Openvox (agent and server), but if you want DB you need to override the package name"?

[evgeni]

This becomes puppet::server_package:

puppet-puppet/manifests/init.pp

Line 704 in b8b34ff

Optional[Variant[String, Array[String]]] $server_package = $puppet::params::server_package,

And then puppet::server::package:

puppet-puppet/manifests/server.pp

Line 408 in b8b34ff

Optional[Variant[String, Array[String]]] $package = $puppet::server_package,

And is then used in

puppet-puppet/manifests/server/install.pp

Line 36 in b8b34ff

$server_package = pick($puppet::server::package, 'puppetserver')

and

puppet-puppet/manifests/server/puppetserver.pp

Line 155 in b8b34ff

$puppetserver_package = pick($puppet::server::package, 'puppetserver')

The later two use pick as they assume puppet::server::package is sometimes Undef, which it isn't anymore after this change.

I think that's totally fine, but should we then get rid of the pick? Just to make it more obvious there are no more fallbacks?

👀 @ekohl