Add unit test for package names

Author: bastelfreak

spec/classes/puppet_init_spec.rb

@@ -10,21 +10,25 @@
         puppet_concat    = '/usr/local/etc/puppet/puppet.conf'
         puppet_directory = '/usr/local/etc/puppet'
         puppet_package   = "puppet#{puppet_major}"
+        openvox_package  = "openvox#{puppet_major}"
         puppetconf_mode  = '0644'
       when 'windows'
         puppet_concat    = 'C:/ProgramData/PuppetLabs/puppet/etc/puppet.conf'
         puppet_directory = 'C:/ProgramData/PuppetLabs/puppet/etc'
         puppet_package   = 'puppet-agent'
+        openvox_package  = 'openvox-agent'
         puppetconf_mode  = '0674'
       when 'Archlinux'
         puppet_concat    = '/etc/puppetlabs/puppet/puppet.conf'
         puppet_directory = '/etc/puppetlabs/puppet'
         puppet_package   = 'puppet'
+        openvox_package  = 'openvox'
         puppetconf_mode  = '0644'
       else
         puppet_concat    = '/etc/puppetlabs/puppet/puppet.conf'
         puppet_directory = '/etc/puppetlabs/puppet'
         puppet_package   = 'puppet-agent'
+        openvox_package  = 'openvox-agent'
         puppetconf_mode  = '0644'
       end
 
@@ -45,6 +49,27 @@
         }
       end
 
+      describe 'with already installed packages' do
+        describe 'legacy Perforce opensource packages' do
+          let :facts do
+            facts.merge(puppet_flavor: 'Puppet')
+          end
+          it { should contain_package(puppet_package)
+            .with_ensure('present')
+            .with_install_options(nil)
+          }
+        end
+        describe 'OpenVox packages' do
+          let :facts do
+            facts.merge(puppet_flavor: 'OpenVox')
+          end
+          it { should contain_package(openvox_package)
+            .with_ensure('present')
+            .with_install_options(nil)
+          }
+        end
+      end
+
       describe 'with server => true', :unless => unsupported_puppetserver_osfamily(facts[:os]['family']) do
         let :params do {
           :server => true,