[Feature request]: Agent variant fact

[krisavi]

Use Case

It could be useful to have agent variant facter, at least when using openvox agent.

Describe the solution you would like

OpenVox agent facter could expose agent variant as "openvox", etc.

Describe alternatives you've considered

Writing custom fact that query package repository to see which one is installed.

Additional context

Could build some logic around that in manifests to install specific agent and repositories. Would be easier to migrate on manifest side and not need some custom fact for it.

[bastelfreak]

There's already a bit of a discussion in theforeman/puppet-puppet#935 about it.

[krisavi]

Thanks for link, but it seems the facter code is in the end responsible for providing that information. It already provides agent version
https://github.com/OpenVoxProject/facter/blob/0656d9a34ce4790129f1fd6eba5bb4d49a9b9ad1/lib/facter/resolvers/aio_agent_version.rb#L17

foreman is another tool that could benefit from it.