Refs #38813 - Remove owner_content_access_mode.modified event from broker filter#274
Merged
ehelms merged 1 commit intotheforeman:masterfrom Oct 10, 2025
Conversation
…oker filter Remove the owner_content_access_mode.modified event as it is no longer needed. Users cannot toggle between SCA and entitlement modes anymore, making this event irrelevant. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
jeremylenz
force-pushed
the
remove-owner-content-access-mode-event
branch
from
8218a38 to
174456d
Compare
jeremylenz
changed the title
ehelms
approved these changes
Oct 10, 2025
Member
|
So close to having no events! |
ekohl
reviewed
Oct 10, 2025
| (EVENT_TARGET='POOL' and EVENT_TYPE='CREATED') OR | ||
| (EVENT_TARGET='POOL' and EVENT_TYPE='DELETED') OR | ||
| (EVENT_TARGET='OWNER_CONTENT_ACCESS_MODE' and EVENT_TYPE='MODIFIED') | ||
| (EVENT_TARGET='POOL' and EVENT_TYPE='DELETED') |
Member
There was a problem hiding this comment.
Isn't this effectively now:
EVENT_TARGET='POOL' and (EVENT_TYPE='CREATED' or EVENT_TYPE='DELETED')
In other words, we only care about pool creations and deletions. So can we also get rid of those? ;)
Contributor
Author
There was a problem hiding this comment.
We can get rid of those as soon as manifests don't need to contain subscriptions anymore. (For now, they still do.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
owner_content_access_mode.modifiedevent from the broker filter as it is no longer neededDetails
Users cannot toggle between SCA and entitlement modes anymore, making this event irrelevant. This completes the work started in the previously merged PR that removed other SCA-irrelevant events.
Test plan
🤖 Generated with Claude Code