Skip to content

Refs #38813 - Remove owner_content_access_mode.modified event from broker filter #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehelms merged 1 commit into from
Oct 10, 2025
Merged

Refs #38813 - Remove owner_content_access_mode.modified event from broker filter #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions templates/broker.xml.epp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@
<address>event.default</address>
<filter string="
(EVENT_TARGET='POOL' and EVENT_TYPE='CREATED') OR
(EVENT_TARGET='POOL' and EVENT_TYPE='DELETED') OR
(EVENT_TARGET='OWNER_CONTENT_ACCESS_MODE' and EVENT_TYPE='MODIFIED')
(EVENT_TARGET='POOL' and EVENT_TYPE='DELETED')
Copy link
Member

@ekohl ekohl Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this effectively now:

EVENT_TARGET='POOL' and (EVENT_TYPE='CREATED' or EVENT_TYPE='DELETED')

In other words, we only care about pool creations and deletions. So can we also get rid of those? ;)

Copy link
Contributor Author

@jeremylenz jeremylenz Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of those as soon as manifests don't need to contain subscriptions anymore. (For now, they still do.)

Copy link
Member

@ekohl ekohl Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to it.

"/>
<forwarding-address>katello.candlepin</forwarding-address>
</divert>
Expand Down
Loading