Fixes #38814 - Remove SCA-irrelevant Candlepin event handling#11523
Merged
jeremylenz merged 2 commits intoKatello:masterfrom Oct 14, 2025
Merged
Fixes #38814 - Remove SCA-irrelevant Candlepin event handling#11523jeremylenz merged 2 commits intoKatello:masterfrom
jeremylenz merged 2 commits intoKatello:masterfrom
Conversation
Remove handling of the following Candlepin events as they are irrelevant in SCA-only mode: - entitlement.created and entitlement.deleted - related to attaching subscriptions to hosts - compliance.created - used to update host subscription status - system_purpose_compliance.created - used to update host system purpose status Also removed orphaned methods that were no longer called: - EventHandler: subscription_facet and reindex_consumer - MessageHandler: create_pool_on_host, remove_pool_from_host, and subscription_facet_host_ids 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
nikosmoum
reviewed
Oct 10, 2025
Also remove handling of the owner_content_access_mode.modified event as it is no longer needed. Users cannot toggle between SCA and entitlement modes anymore, making this event irrelevant. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
7438642 to
2156070
Compare
Member
Author
|
Removed handling of the owner_content_access_mode.modified events. Also updated theforeman/foremanctl#247 and opened a new PR theforeman/puppet-candlepin#274 since the puppet-candlepin one was already merged |
Member
Author
|
All installer changes are now merged. |
Member
|
All import manifest, refresh manifest, install errata and install a package worked well. |
lfu
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theforeman/puppet-candlepin#273
theforeman/puppet-candlepin#274
theforeman/foremanctl#247
^ these should be merged firstthey're merged nowWhat are the changes introduced in this pull request?
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Remove handling of the following Candlepin events as they are
irrelevant in SCA orgs:
attaching subscriptions to hosts
purpose status
Also removed orphaned methods that were no longer called:
and subscription_facet_host_ids
Considerations taken when implementing this change?
Installer changes should be in place first.
What are the testing steps for this pull request?
Make sure the following continue to work as expected:
Manifest refresh / import
Host content access
Summary by Sourcery
Remove support for SCA-irrelevant Candlepin events and clean up associated code, tests, and fixtures.
Enhancements:
Tests:
Summary by Sourcery
Remove support for Candlepin events that are irrelevant to SCA orgs and clean up associated code and tests
Enhancements:
Tests:
Chores: