Fixes #38663 - Host details kebab inconsistent ui#10650
Merged
jeremylenz merged 1 commit intotheforeman:developfrom Aug 25, 2025
Merged
Fixes #38663 - Host details kebab inconsistent ui#10650jeremylenz merged 1 commit intotheforeman:developfrom
jeremylenz merged 1 commit intotheforeman:developfrom
Conversation
MariaAga
force-pushed
the
host-dropdown-update
branch
from
3847958 to
006a3c6
Compare
MariaAga
force-pushed
the
host-dropdown-update
branch
from
006a3c6 to
ff12abc
Compare
kmalyjur
suggested changes
Aug 19, 2025
Contributor
kmalyjur
left a comment
kmalyjur
left a comment
There was a problem hiding this comment.
Is it on purpose that the dropdown is without the border? 🤔
webpack/assets/javascripts/react_app/components/HostDetails/ActionsBar/index.js
Outdated
Show resolved
Hide resolved
MariaAga
force-pushed
the
host-dropdown-update
branch
from
ff12abc to
7ba385c
Compare
Member
Author
|
the isplain prop was there before, but it does look better with the shadow so I removed it |
Contributor
|
@MariaAga Thanks. Do you know what's going on with the failing tests? |
Member
Author
|
Not sure, but these look like the regular tests that fail in gh actions |
jeremylenz
approved these changes
Aug 25, 2025
Contributor
jeremylenz
left a comment
jeremylenz
left a comment
There was a problem hiding this comment.
Test failures are unrelated.
thanks @MariaAga !
MariaAga
added
the
Needs cherrypick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will need 4 plugin updates