Skip to content

Fixes #38666 - update Dropdown in host details actions#11472

Merged
jeremylenz merged 1 commit intoKatello:masterfrom
MariaAga:host-dropdown-update
Aug 25, 2025
Merged

Fixes #38666 - update Dropdown in host details actions#11472
jeremylenz merged 1 commit intoKatello:masterfrom
MariaAga:host-dropdown-update

Conversation

@MariaAga
Copy link
Contributor

@MariaAga MariaAga commented Aug 14, 2025

should be merged with theforeman/foreman#10650

Summary by Sourcery

Update host details actions dropdown to use internal routing via to prop and replace the separator with the Divider component.

Bug Fixes:

  • Use to prop in DropdownItem instead of href for correct internal navigation

Enhancements:

  • Replace DropdownSeparator with Divider in the HostActionsBar dropdown

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request refactors the HostActionsBar dropdown items to use router-based navigation props and updates the separator component to match the current PatternFly standards.

Class diagram for updated HostActionsBar Dropdown items

classDiagram
    class HostActionsBar {
        +DropdownItem[]
        +Divider
        +showRecalculate
    }
    class DropdownItem {
        +to: string
        +icon: ReactElement
        +children: string
    }
    class Divider {
    }
    HostActionsBar --> DropdownItem
    HostActionsBar --> Divider
Loading

Class diagram for DropdownItem prop changes

classDiagram
    class DropdownItem {
        -href: string
        +to: string
        +icon: ReactElement
        +children: string
    }
Loading

File-Level Changes

Change Details Files
Switch DropdownItem links from href to router 'to' prop
  • Replaced href with to on the legacy content host UI link
  • Replaced href with to on the change host content source link
webpack/components/extensions/HostDetails/ActionsBar/index.js
Replace DropdownSeparator with Divider
  • Removed DropdownSeparator import and usage
  • Added Divider component in its place
webpack/components/extensions/HostDetails/ActionsBar/index.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lfu
Copy link
Member

lfu commented Aug 25, 2025

kebab

Copy link
Member

@lfu lfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylenz
Copy link
Member

Test failures unrelated; merging

@jeremylenz jeremylenz merged commit e4530b8 into Katello:master Aug 25, 2025
24 of 26 checks passed
pavanshekar pushed a commit to pavanshekar/katello that referenced this pull request Aug 26, 2025
pavanshekar added a commit that referenced this pull request Aug 26, 2025
* Release 4.18.0.rc1

* Fixes #38652 - Show preset CV filter rule values on edit (#11466)

(cherry picked from commit cc4c90c)

* Fixes #38635 - Add static OUIA IDs to PF5 widgets on CV page

(cherry picked from commit 5c765af)

* Fixes #38672 - yum_or_yum_transient with defaults (#11476)

The call got delegated to a facet which may not have existed, in which
case a nil was returned

(cherry picked from commit f4eb4c7)

* Fixes #38675 - Registry Search Parameter Default:* (search all) can return incomplete results (#11478)

(cherry picked from commit d518a5f)

* Fixes #38666 - update Dropdown in host details actions (#11472)

(cherry picked from commit e4530b8)

---------

Co-authored-by: Nadja Heitmann <nadjah@atix.de>
Co-authored-by: Adam Růžička <adamruzicka@users.noreply.github.com>
Co-authored-by: Samir Jha <samirjha1525@gmail.com>
Co-authored-by: Maria <mariaaga@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants