Fixes #38666 - update Dropdown in host details actions#11472
Merged
jeremylenz merged 1 commit intoKatello:masterfrom Aug 25, 2025
Merged
Fixes #38666 - update Dropdown in host details actions#11472jeremylenz merged 1 commit intoKatello:masterfrom
jeremylenz merged 1 commit intoKatello:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis pull request refactors the HostActionsBar dropdown items to use router-based navigation props and updates the separator component to match the current PatternFly standards. Class diagram for updated HostActionsBar Dropdown itemsclassDiagram
class HostActionsBar {
+DropdownItem[]
+Divider
+showRecalculate
}
class DropdownItem {
+to: string
+icon: ReactElement
+children: string
}
class Divider {
}
HostActionsBar --> DropdownItem
HostActionsBar --> Divider
Class diagram for DropdownItem prop changesclassDiagram
class DropdownItem {
-href: string
+to: string
+icon: ReactElement
+children: string
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
4 tasks
Member
Member
|
Test failures unrelated; merging |
pavanshekar
pushed a commit
to pavanshekar/katello
that referenced
this pull request
Aug 26, 2025
(cherry picked from commit e4530b8)
pavanshekar
added a commit
that referenced
this pull request
Aug 26, 2025
* Release 4.18.0.rc1 * Fixes #38652 - Show preset CV filter rule values on edit (#11466) (cherry picked from commit cc4c90c) * Fixes #38635 - Add static OUIA IDs to PF5 widgets on CV page (cherry picked from commit 5c765af) * Fixes #38672 - yum_or_yum_transient with defaults (#11476) The call got delegated to a facet which may not have existed, in which case a nil was returned (cherry picked from commit f4eb4c7) * Fixes #38675 - Registry Search Parameter Default:* (search all) can return incomplete results (#11478) (cherry picked from commit d518a5f) * Fixes #38666 - update Dropdown in host details actions (#11472) (cherry picked from commit e4530b8) --------- Co-authored-by: Nadja Heitmann <nadjah@atix.de> Co-authored-by: Adam Růžička <adamruzicka@users.noreply.github.com> Co-authored-by: Samir Jha <samirjha1525@gmail.com> Co-authored-by: Maria <mariaaga@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

should be merged with theforeman/foreman#10650
Summary by Sourcery
Update host details actions dropdown to use internal routing via
toprop and replace the separator with theDividercomponent.Bug Fixes:
toprop in DropdownItem instead ofhreffor correct internal navigationEnhancements: