SAT-37810 - Update Total risks card dropdown for PF5

[lfu]

What are the changes introduced in this pull request?

Depends on theforeman/foreman#10685

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by Sourcery

Migrate the Total Risks card dropdown in the host insights details tab to use PatternFly 5 components and styles, update its menu options and behavior for risk filtering

Enhancements:

• Migrate the dropdown in InsightsTotalRiskChart to PatternFly 5’s Dropdown component
• Update dropdown menu items and event handlers for selecting risk filters
• Adjust CSS classes and layout to match PF5 styling guidelines

Tests:

• Add tests for dropdown filter selection in the Total Risks chart

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the total risks dropdown in InsightsTotalRiskChart to use PatternFly 5 components, updating imports, markup, styling, and event handling to align with the new library API.

File-Level Changes

Change	Details	Files
Swap PF4 Dropdown for PF5 menu components	Import Menu, MenuToggle, MenuList, and MenuItem from PF5 Replace DropdownToggle and DropdownItem implementations Update state hook for menu open/close handling	webpack/InsightsHostDetailsTab/InsightsTotalRiskChart.js
Adjust styling and class names to PF5 conventions	Remove legacy pf-c-dropdown modifiers Add appropriate pf-c-menu and pf-c-list classes Update CSS tokens and spacing variables	webpack/InsightsHostDetailsTab/InsightsTotalRiskChart.js
Update selection event handling	Switch from onSelect to onClick handlers on menu items Ensure selected value state updates correctly Trigger callback with new risk filter value	webpack/InsightsHostDetailsTab/InsightsTotalRiskChart.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[chris1984]

Looks good, tests need looked at:

[chris1984]

@lfu looks like it needs some spacing, here is content view environment and how it should look:

[lfu]

@MariaAga What do you think about this patch? Is there a way to fix it without manual CSS changes?

[MariaAga]

@lfu is this tested with the foreman fix for card template?

[lfu]

@MariaAga Not sure what fix you referred to. But I'm running the latest Foreman code.

[MariaAga]

My bad I thought it was done but it was a similar fix in theforeman/foreman#10650
You need to update CardTemplate dropdown as well as the plugin one (so for this its rh_cloud and remote_execution)
/webpack/assets/javascripts/react_app/components/HostDetails/Templates/CardItem/CardTemplate/index.js
Its described here: https://issues.redhat.com/browse/SAT-37676 (I'll link the issues)

[jeremylenz]

Thanks all! ACK 👍

[lfu]

Foreman PR is not merged yet.