Skip to content

Fixes #38435 - remove select2 tooltips#10546

Merged
ofedoren merged 1 commit intotheforeman:developfrom
MariaAga:remove-tooltip-select2
Jul 8, 2025
Merged

Fixes #38435 - remove select2 tooltips#10546
ofedoren merged 1 commit intotheforeman:developfrom
MariaAga:remove-tooltip-select2

Conversation

@MariaAga
Copy link
Copy Markdown
Member

Removed the work arounds to try to make the tooltips works
removed all tooltips
sometimes they are re-added when a select happens (sometimes because a new part of the page is added), so also remove them on select.
It breaks tests randomly with no way to fix them otherwise

@github-actions github-actions Bot added the Legacy JS PRs making changes in the legacy Javascript stack label May 21, 2025
@ekohl
Copy link
Copy Markdown
Member

ekohl commented May 21, 2025

Is there a way we could drop the select2 dependency altogether? Any idea how many select2 tooltips we have in our codebase(s)?

@MariaAga
Copy link
Copy Markdown
Member Author

I dont see how, as just updating it was such a pain, replacing it and keeping the functionality in all different uses and plugins will be very difficult.
the tooltips are added by select2 to the clear button, and to the select2 result bar/span

@MariaAga
Copy link
Copy Markdown
Member Author

image

@ekohl
Copy link
Copy Markdown
Member

ekohl commented May 21, 2025

I dont see how, as just updating it was such a pain, replacing it and keeping the functionality in all different uses and plugins will be very difficult.

I see it is indeed used widely. I'd like to hear your thoughts on how to remove it. Do we have a replacement? If so, can we at least deprecate it for us developers?

@MariaAga
Copy link
Copy Markdown
Member Author

how to remove it - probably by replacing all .html.erb to react, otherwise were working hard on a code that we will delete later anyway

@ekohl
Copy link
Copy Markdown
Member

ekohl commented May 21, 2025

I fear you're right.

@nadjaheitmann
Copy link
Copy Markdown
Contributor

I had the integration test in foreman_puppet running against this PR as this is where it popped up and now it works just fine 👍

@nadjaheitmann
Copy link
Copy Markdown
Contributor

Is there anything preventing this one from being merged? Would love to have the foreman_puppet CI to be green again :)

Copy link
Copy Markdown
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga ! I hope no one will miss them, I personally don't think they added any real value, just repeating what's already can be seen. Although, users might be thinking that something got broken so they don't see the tooltips as before. Should we explicitly say in e.g. release note about that?

@MariaAga
Copy link
Copy Markdown
Member Author

MariaAga commented Jun 10, 2025

currently they disappear if hovered more than once so they are barely there?

@ofedoren ofedoren merged commit b8db1e1 into theforeman:develop Jul 8, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Legacy JS PRs making changes in the legacy Javascript stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants