Fixes #38435 - remove select2 tooltips#10546
Conversation
|
Is there a way we could drop the select2 dependency altogether? Any idea how many select2 tooltips we have in our codebase(s)? |
|
I dont see how, as just updating it was such a pain, replacing it and keeping the functionality in all different uses and plugins will be very difficult. |
I see it is indeed used widely. I'd like to hear your thoughts on how to remove it. Do we have a replacement? If so, can we at least deprecate it for us developers? |
|
how to remove it - probably by replacing all .html.erb to react, otherwise were working hard on a code that we will delete later anyway |
|
I fear you're right. |
|
I had the integration test in foreman_puppet running against this PR as this is where it popped up and now it works just fine 👍 |
|
Is there anything preventing this one from being merged? Would love to have the foreman_puppet CI to be green again :) |
ofedoren
left a comment
There was a problem hiding this comment.
Thanks, @MariaAga ! I hope no one will miss them, I personally don't think they added any real value, just repeating what's already can be seen. Although, users might be thinking that something got broken so they don't see the tooltips as before. Should we explicitly say in e.g. release note about that?
|
currently they disappear if hovered more than once so they are barely there? |

Removed the work arounds to try to make the tooltips works
removed all tooltips
sometimes they are re-added when a select happens (sometimes because a new part of the page is added), so also remove them on select.
It breaks tests randomly with no way to fix them otherwise