Update integration tests for jquery3 part 2#424
Conversation
f1f733c to
6e6fce4
Compare
6e6fce4 to
a41b44e
Compare
|
@MariaAga Do you have any idea why the integration tests are failing and how to fix it? https://github.com/theforeman/foreman_puppet/actions/runs/15041967945/job/42275651182?pr=424#step:21:30 We tried to debug it but could not reproduce the error locally. |
|
This took awhile, so recording the debugging: function onContentLoad() {
const targetNode = document.querySelector('body');
const config = { attributes: true, childList: true, subtree: true };
const callback = (mutationList, observer) => {
for (const mutation of mutationList) {
if (mutation.type === "childList") {
mutation.addedNodes.forEach( n =>
{
if (n?.classList?.length && [...n.classList].includes('tooltip')){
console.log('TOOLTIPHERE')
console.log(n.innerHTML)
}
}
)
}
};
const observer = new MutationObserver(callback);
observer.observe(targetNode, config);Then I ran I tried clicking in random places before and after the OS tab change and nothing helped. BTW: |
|
Thanks @MariaAga , I had the PR running against your PR and it runs fine now. |
|
@nadjaheitmann The PR in foreman was merged, could you please drop 5364155 ? |
02196ce to
0719026
Compare
|
The test failures were not introduced here, opened #425 to address that |
|
Thank you @nadjaheitmann ! |
For some reason, the integration tests were not run on the second push in #423, which we realized only after merging. So here is a fixup PR.