Skip to content

Fixes #38435 - remove select2 tooltips #10546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofedoren merged 1 commit into from
Jul 8, 2025
Merged

Fixes #38435 - remove select2 tooltips #10546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 15 additions & 52 deletions app/assets/javascripts/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,31 +35,20 @@ $(document).on('click', 'a[disabled="disabled"]', function(event) {
return handleDisabledClick(event, this);
});

const autoUpdateSelect2Titles = function() {
const targetNodes = document.querySelectorAll(
'.select2-selection__rendered'
);

const config = { attributes: true, attributeFilter: ['title'] };

const callback = function(mutationsList) {
for (let mutation of mutationsList) {
if (
mutation.type === 'attributes' &&
mutation.attributeName === 'title'
) {
mutation.target.setAttribute(
'data-original-title',
mutation.target.getAttribute('title')
);
}
const removeSelect2TitlesTooltips = function() {
// select2 tooltips dont update and dont close properly
$('.select2-selection span').attr('title', '');
$('.select2-selection__rendered').attr('title', '');
$('.select2-selection__clear').attr('title', '');
$(document).on(
'select2:select select2:unselecting',
'.select2-hidden-accessible',
function() {
$('.select2-selection span').attr('title', '');
$('.select2-selection__rendered').attr('title', '');
$('.select2-selection__clear').attr('title', '');
}
};

targetNodes.forEach(targetNode => {
const observer = new MutationObserver(callback);
observer.observe(targetNode, config);
});
);
};

function onContentLoad() {
Expand Down Expand Up @@ -118,33 +107,7 @@ function onContentLoad() {
.remove();
});

const hideSelect2ClearTooltip = function() {
$(document).on('blur', '.select2-selection__clear', function() {
$('.tooltip').tooltip('hide');
});

const targetNode = document.querySelector('body');
const config = { attributes: false, childList: true, subtree: true };
const callback = function(mutationsList) {
for (let mutation of mutationsList) {
if (mutation.type === 'childList') {
const node = Array.from(mutation.removedNodes).find(
node =>
node.classList &&
node.classList.contains('select2-selection__clear')
);
if (node) {
$('.tooltip').tooltip('hide');
}
}
}
};
const observer = new MutationObserver(callback);
observer.observe(targetNode, config);
};

hideSelect2ClearTooltip();
autoUpdateSelect2Titles();
removeSelect2TitlesTooltips();
}

function preserve_selected_options(elem) {
Expand Down Expand Up @@ -412,7 +375,7 @@ function reloadOnAjaxComplete(element) {
activate_select2(':root');
tfm.advancedFields.initAdvancedFields();
tfm.templateInputs.initTypeChanges();
autoUpdateSelect2Titles();
removeSelect2TitlesTooltips();
}

function set_fullscreen(element) {
Expand Down
Loading