Skip to content

Conversation

@lhw2002426
Copy link
Contributor

fix python path problem mentioned in #14
restructures the entire codebase into a single, unified robonix Python package. All internal module imports now consistently use absolute paths starting with robonix. (e.g., from robonix.manager.node import *).
The start.sh script now automatically adds the project's root directory to the PYTHONPATH, ensuring the unified package is always discoverable at runtime.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Python path issues by restructuring the codebase into a unified robonix package with consistent absolute imports. The main change is adding automatic PYTHONPATH configuration in start.sh and removing manual sys.path manipulation scattered throughout the code.

Key Changes:

  • Added PYTHONPATH export to start.sh to automatically include the project root
  • Removed manual sys.path manipulation code from multiple skill and brain modules
  • Updated imports in manager modules to use the robonix.manager prefix

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
start.sh Adds script directory navigation and PYTHONPATH export to ensure robonix package is discoverable
robonix/skill/test_skill/api/api.py Removes manual sys.path manipulation code
robonix/skill/test.py Removes manual sys.path manipulation code
robonix/skill/semantic_map/test_semantic_map.py Removes manual sys.path manipulation code but import not updated to use robonix prefix
robonix/skill/move/api/api.py Removes manual sys.path manipulation code
robonix/manager/process_manage.py Updates import to use robonix.manager prefix
robonix/manager/node.py Updates imports to use robonix.manager prefix
robonix/manager/eaios_decorators.py Updates import to use robonix.manager prefix but retains some sys.path manipulation
robonix/manager/depend.py Updates imports to use robonix.manager prefix
robonix/manager/cmdline.py Updates import to use robonix.manager prefix
robonix/manager/boot.py Updates imports to use robonix.manager prefix but retains sys.path manipulation for BASE_PATH
robonix/capability/navigation2/plugins/ros2_navigation/lib.py Adds rclpy initialization checks
robonix/capability/navigation2/api/api.py Adds Iterable type import and rclpy initialization checks
robonix/brain/test_mcp/server.py Removes manual sys.path manipulation code
robonix/brain/test_mcp/main.py Removes manual sys.path manipulation code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@enkerewpo enkerewpo merged commit 8429af8 into syswonder:main Jan 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants