-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #545 text color of "about us" option and "news" option #565
Conversation
Thanks. Reviewed.
Can you explain why you have chosen ul? Reference: https://getbootstrap.com/docs/4.0/components/navbar/ |
@quozl I haven't used |
Thanks. Reviewed. Looked at history; was this problem introduced by 7088c6d? Updated issue. |
@quozl No it wasn't that commit aims to resolve the responsiveness of the navbar. |
Thanks. I've dug deeper, the practice was in the original GSoC 2017 commit 725368d, with Bootstrap 3.3.7, for which the documentation is not easily available, but in tag v3.3.7 file docs/examples/navbar/index.html the practice is clearly present. Therefore our upgrade to Bootstrap 4.0.0 in 99eabc0 may have been incomplete. |
@quozl Is the review process completed? or anything is left to be fixed. |
Thanks for your patience. Delay was due to contributions to the issue by others who wanted to fix the problem, but in the end didn't want the problem fixed enough to help us fix it. I sought consensus but there was no useful response within a reasonable time. |
Fixes #545


This is how it look like
@quozl @pikurasa please review.