Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 545: text color of 'about us' option and 'news' option #550

Closed
wants to merge 2 commits into from

Conversation

Lakshya0257
Copy link

Fixed the issue raised in #545

Issue

Navbar tabs were showing two different colors in two different window sizes.

Fix

  • Fixed by modifying the nav.html without affecting any other behaviour.

Output

image
image

@therealharshit
Copy link
Member

@Lakshya0257 I think it would be much better if it looks like 384690688-1d9f3ad2-b349-4ef0-abfb-85e5ae915db2.png

On both the screen size.

@Lakshya0257
Copy link
Author

@therealharshit I have modified according to your requirements, kindly review it now.

image

@therealharshit
Copy link
Member

@Lakshya0257 the changes you made didn't fix this issue, it has also also affected the previous behavior of navbar.
Vedio:

nav.mp4

@Sushant0124
Copy link

@therealharshit Is the issue is still there??

@pikurasa
Copy link
Contributor

@Sushant0124 once you get this "camera ready", please put it on a new branch and open up a new PR. It's a very important habit to get into.

Please refer to https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#making-commits for best practices.

@quozl
Copy link
Contributor

quozl commented Nov 30, 2024

@Lakshya0257 please review #565 and decide if you want #550 to continue.

@quozl
Copy link
Contributor

quozl commented Dec 2, 2024

You did not respond, so I decided #565 was the better solution and merged it. Closing this pull request.

@quozl quozl closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants