Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text color of "about us" option and "news" option #545

Closed
Ajaykumar724 opened this issue Nov 10, 2024 · 27 comments · Fixed by #565
Closed

text color of "about us" option and "news" option #545

Ajaykumar724 opened this issue Nov 10, 2024 · 27 comments · Fixed by #565

Comments

@Ajaykumar724
Copy link

when i adjust width of website to smaller then 1215px , options text color is grey
i also attach screenshot
Screenshot 2024-11-10 182313
but website width is greater than 1215px , options text color is blue
see below screenshot
Screenshot 2024-11-10 182007
this is responsive error must be resolve that
thank you.

@therealharshit
Copy link
Member

@Ajaykumar724 you can work on this, but make sure it didn't break the navbar.

@Ajaykumar724

This comment was marked as off-topic.

@therealharshit

This comment was marked as off-topic.

@Ajaykumar724

This comment was marked as off-topic.

@therealharshit

This comment was marked as off-topic.

@nilaygit-10721

This comment was marked as off-topic.

@therealharshit

This comment was marked as off-topic.

@nilaygit-10721

This comment was marked as off-topic.

@Lakshya0257
Copy link

I have figured out the problem and solved the same, kindly review my PR for the same #550

@Sushant0124

This comment was marked as off-topic.

@therealharshit

This comment was marked as off-topic.

@Sushant0124

This comment was marked as off-topic.

@Sushant0124

This comment was marked as off-topic.

@therealharshit

This comment was marked as off-topic.

@quozl
Copy link
Contributor

quozl commented Nov 15, 2024

Thanks for getting involved. Perhaps you all might keep discussion on issues on topic? It has got difficult for a reviewer to figure out the consensus on this issue, because of all the off-topic posts. I shall hide the off-topic posts.

I'd like the menu items to be foreground black regardless of screen size, but really that should be a decision of Bootstrap. I'd like to know why it isn't working the way we expect; and speculate one or more of these causes;

  • our code does not label elements correctly,
  • our code includes something that breaks what Bootstrap does, or; ◀️
  • the way we expect is wrong and Bootstrap is right.

@therealharshit
Copy link
Member

@quozl it's not the decision of bootstap it's the airspace.css in which the style .dropdown-menu li a{ color: #0099ff !important; } is responsible for that blue color of dropdown menu, when we change the style to .dropdown-menu li a{ color:black !important; } it changes the color to black
dropdown
but for this we need to modify airspace.css which I think go against a long term goal of using a theme without changes.

@quozl
Copy link
Contributor

quozl commented Nov 17, 2024

So use custom.css, or go back to the upstream Jekyll Airspace theme on GItHub and remove our changes that broke this? Is what we observe the upstream choice?

@aneesafatima
Copy link

Is this issue resolved?

@therealharshit
Copy link
Member

Is this issue resolved?

Not yet, if you want you can work on it.

@aneesafatima
Copy link

May I ask why changing the airspace.css is not considered a solution? It we make it to black then it is no longer blue which solves this color issue.

@therealharshit
Copy link
Member

May I ask why changing the airspace.css is not considered a solution? It we make it to black then it is no longer blue which solves this color issue.

@aneesafatima we are using jekyll airspace theme for our website and making changes to airspace.css go against a long term goal of using a theme without changes.
This issue can still be resolved by making some changes to nav.html.

@quozl
Copy link
Contributor

quozl commented Nov 26, 2024

I don't think this issue requires it, but also welcome is changing airspace.css so that it is less different to what it was upstream, at the same time as adding our changes to other files.

@yashsaraswat2004
Copy link

Hey, can I work on this issue?

@quozl
Copy link
Contributor

quozl commented Nov 29, 2024

Welcome. Please join in. But sorry, I don't understand. Why can't you fix it without asking? You are asking for the right to be the only one to fix it? We can't offer that right. Anyone could fix it.

@quozl
Copy link
Contributor

quozl commented Nov 30, 2024

Dear @Ajaykumar724 (issue presenter), @nilaygit-10721 (asked if issue is unresolved) @Lakshya0257 (tried to solve with #550), @Sushant0124 (asked if the issue is unresolved), @krAtOsnana (tried to solve with #552), @aneesafatima (asked if the issue is unresolved), @yashsaraswat2004 (asked to work on the issue),

Please review #565 .

Not sure how to review? See our guide for reviewers.

I was ready to merge, but found this issue has a large number of participants, so would like to ensure you all have a say in the review process. Thanks!

@ad1tyayadav
Copy link

Hello @quozl can you please check my PR too :)
ad1tyayadav@59c5135

@quozl
Copy link
Contributor

quozl commented Dec 2, 2024

Thanks @ad1tyayadav, I've reviewed it. I think you misplaced your effort; for this issue it would have been better for you to review #565 rather than try to fix the problem in another way.

I've given a chance for you all to review #565 and there was no reply; this signals that either none of you were available or that none of you were willing to review. Please get involved next time.

I'll proceed with finalising #565.

@quozl quozl closed this as completed in #565 Dec 2, 2024
quozl pushed a commit that referenced this issue Dec 2, 2024
* Fix dropdown structure: Remove unnecessary <li> tag for better responsiveness

* Refactor: Change dropdown-menu tag from <ul> to <div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants