Default map min_zoom of 5 - #19
Merged
Merged
Conversation
SepalMap never set min_zoom, so the map inherited ipyleaflet's 0. Floor zoom-out at level 5, overridable via the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvaged from the stale PR #11, which is being closed: its other two commits are already in main (chart theming landed with #13) or superseded (the Voila fix — pysepal 3.8.1 resolves the runtime under Voila itself, and the tile-client tweak is covered by the comm bridge from #16).
SepalMapnever setmin_zoom, so the map inherited ipyleaflet's 0. This floors zoom-out at level 5, overridable via the constructor.Note the side effect: leaflet clamps the initial view up to
minZoom, so with SepalMap's defaultcenter=[0,0], zoom=2the app now opens at roughly 44 degrees across rather than a world view, andfit_boundscan't fit a raster wider than that.Tests: 200 passed.