Voila rendering, map min_zoom, and analysis chart theming - #11
Closed
dfguerrerom wants to merge 3 commits into
Closed
Voila rendering, map min_zoom, and analysis chart theming#11dfguerrerom wants to merge 3 commits into
dfguerrerom wants to merge 3 commits into
Conversation
Thread the app theme_toggle down to AreaEstimateChart and set a transparent backgroundColor so it stops showing ECharts' dark theme #100c2a fill.
dfguerrerom
force-pushed
the
pr/sample-design-simple
branch
from
July 14, 2026 13:48
9fbbaad to
14816e8
Compare
Contributor
Author
|
Superseded — closing. The branch's merge-base is #10, so it predates #13/#14/#16/#17/#18 and merging it would revert ~3,500 lines (analysis dashboard, vector_tiles, PMTiles points, tile bridge, 11 test files). Of its three commits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up UI work on the sample-design branch, on top of the (already merged) PR #10.
Three commits:
min_zoomof 5 —SbaeMapnow floors zoom-out at level 5 (roughly continental), overridable via the constructor.SepalMapnever setmin_zoom, so it previously inherited ipyleaflet's0.theme_toggledown toAreaEstimateChartand set a transparentbackgroundColor(#1e1e1e00), so it stops showing ECharts' built-in dark-theme#100c2afill and tracks the theme toggle in lockstep with the summary pie/precision charts.Tests:
111 passed.