Add blobtk depth for read coverage#171
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.2.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
- Remove cpus limit as blobtk depth is single-threaded - Adjust coverage file name - Fix typos Co-authored-by: Matthieu Muffato <mm49@sanger.ac.uk>
muffato
left a comment
There was a problem hiding this comment.
Can you update the CHANGELOG too ?
I can reproduce the issue with -resume you were saying this morning. Did you find out why ? If you run Nextflow with -dump-hashes you can find out what changes between runs, cf https://www.nextflow.io/docs/latest/cache-and-resume.html#comparing-the-hashes-of-two-runs
- `process_*` don't exist in this pipeline. The defaults resources are already for single CPU use - No need to invoke a container, the host must have `ln` - Therefore no need to report versions
- CHANGE_NAME is always called and is the only place where the published file name is set - All downstream modules use the renamed BAMs as input and copy its name to the output
We don't publish anything from CHANGE_NAME itself. Instead we make SAMTOOLS_INDEX publish its input file.
5034665 to
9e02bf0
Compare
"change_name" process and configuration of output file name
muffato
left a comment
There was a problem hiding this comment.
I've just found there's an issue with the BAM output !
When running this branch with the --outfmt bam option, the output (BAM) files only contain the header, not any read alignment.
|
And another issue is that |
|
I've run some tests (CRAM/BAT/both, and with/without header). No issue about empty BAM file like this morning. In BAM + no-header mode, the BAM files are not published (but the BAI are) (to enable the no-header mode, I edit |
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).