Conversation
Contributor
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.2.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
sainsachiko
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request is inspired by our discussion this morning on the problems with
-resumeyou've faced when testing these changes for #171.ch_baiis meant to be the channel of the BAM index that is then used as an output of the sub-worfkflow (inemit:). The same variable name should be used when initialising it to an empty channel, getting the output of SAMTOOLS_REINDEX, and putting into ch_data_for_stats.It's good to add support for CSI, but the way the nf-core samtools module works, they're in different output channels and mutually exclusive. Rather than changing to just CSI, I propose to simply mix the two channels. So that
ch_bairemains the one variable we use, and it will have whatever index was created by samtools.I don't know if this change would have fixed your issue with
-resume, I haven't tested that.PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).