Skip to content

Support CSI files too#173

Merged
muffato merged 1 commit into
devfrom
bai_csi
Jun 25, 2025
Merged

Support CSI files too#173
muffato merged 1 commit into
devfrom
bai_csi

Conversation

@muffato

@muffato muffato commented Jun 24, 2025

Copy link
Copy Markdown
Member

This pull-request is inspired by our discussion this morning on the problems with -resume you've faced when testing these changes for #171.

ch_bai is meant to be the channel of the BAM index that is then used as an output of the sub-worfkflow (in emit:). The same variable name should be used when initialising it to an empty channel, getting the output of SAMTOOLS_REINDEX, and putting into ch_data_for_stats.
It's good to add support for CSI, but the way the nf-core samtools module works, they're in different output channels and mutually exclusive. Rather than changing to just CSI, I propose to simply mix the two channels. So that ch_bai remains the one variable we use, and it will have whatever index was created by samtools.

I don't know if this change would have fixed your issue with -resume, I haven't tested that.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@muffato muffato requested a review from sainsachiko June 24, 2025 11:01
@muffato muffato self-assigned this Jun 24, 2025
@sanger-tolsoft

Copy link
Copy Markdown
Contributor

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@muffato muffato merged commit 0357a02 into dev Jun 25, 2025
5 checks passed
@muffato muffato deleted the bai_csi branch June 25, 2025 15:04
@muffato muffato added this to the v1.4.0 milestone Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants