Read coverage review#176
Merged
Merged
Conversation
- `process_*` don't exist in this pipeline. The defaults resources are already for single CPU use - No need to invoke a container, the host must have `ln` - Therefore no need to report versions
Contributor
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.2.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
sainsachiko
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(reopening because I accidentally closed #175)
This is the first part of my review of #171. I was testing things locally and thought I'd just push my changes as a pull-request for you to review rather than adding comments onto your PR.
samtools/faidxwhich wasn't used.blobtk_depthbecause we pass a BAM file, not CRAM.subworkflows/local/convert_stats.nfsubworkflows/local/convert_stats.nf, ch_cram was getting BAM, not CRAM.modules/local/change_name.nf, in order to make it ligher:localexecutor.lnto exist on the host.process_*labels. But the defaults resources are already for 1 CPU-foption inlnfor re-runs, just in casePR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).