Repository navigation
Release v0.18.0: release notes, sync v6 and embedding help docs, READMEs - #123
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f64f585d1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d worker failure recovery
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8701f80b5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review of
All previously active inline findings now have addressed replies from the author; the fixes verified in earlier rounds remain in place at HEAD. Files Reviewed (4 files, incremental)
Previous Review Summaries (10 snapshots, latest commit f2f0993)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f2f0993)Status: No Issues Found | Recommendation: Merge Incremental review of
No active findings remain against current code. Files Reviewed (4 files, incremental)
Previous review (commit d0fa44a)Status: No Issues Found | Recommendation: Merge Incremental review of
Both defects addressed by this commit were previously reported in inline comments (sync-data-service.ts:1381, memory-service.ts:233) and are now resolved; no active findings remain against current code. Files Reviewed (5 files, incremental)
Previous review (commit c81f21c)Status: No Issues Found | Recommendation: Merge Incremental review of
No previously reported findings remain against current code. Files Reviewed (9 files, incremental)
Previous review (commit 20f83d7)Status: No Issues Found | Recommendation: Merge Incremental review of
No previously reported findings remain against current code. Files Reviewed (7 files, incremental)
Previous review (commit d58f39a)Status: No Issues Found | Recommendation: Merge Incremental review of Files Reviewed (21 files, incremental)
Previous review (commit 10a4fa6)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (10 files, incremental d6b9b72..10a4fa6)
Incremental scope: reviewed Fix these issues in Kilo Cloud Previous review (commit d6b9b72)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Incremental scope: reviewed Previous review (commit a371336)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (10 files)
Incremental scope: reviewed Previous review (commit 45af95d)Status: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Previous review (commit 6d9df9d)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (30 files)
事实核查(文档声明 vs 代码实现)以下关键声明均已对照代码验证一致:16 个章节小组( Reviewed by glm-5.3 · Input: 58.9K · Output: 9.3K · Cached: 423.4K |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45af95d98f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3713365d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10a4fa6f49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ng keyword matches
…te failures in legacy sync
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dce2dd5a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…larify memory query hint
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d58f39a44c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rect catalog upload docs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20f83d7945
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ep sync import type checks
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c81f21cc39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0fa44ae8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2f0993c4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Release prep for v0.18.0. It bumps the version and adds the release notes, help doc fixes and README updates for the 17 commits on
mainsince v0.17.0. The main changes are sync protocol v6 with chapter-group incremental sync, large-library sync and leftover Gist file cleanup, plus the switch to Bekko local embeddings running in a Web Worker with a redesigned 向量索引 panel.package.jsongoes to0.18.0; the pre-commit hook setsrc/constants/version.tsto0.18.0.16(one bump per commit, including review fixes)New
public/releaseNotes/RELEASE_NOTES_v0.18.0.md(Chinese), covering:hotchpotch/bekko-embedding-v1-a25m, 384-d, ~190 MiB for both backends), source-only chapter vectors with re-ranking, WebGPU probing and the Transformers.js recovery patch@noble/hashesdependency andpatches/for transformerspublic/help/{zh-CN,zh-TW,en-US}/index.json: v0.18.0 entry added above v0.17.0; zh-CN / zh-TWlocal-embeddingdescriptions updated from GTE / 批量嵌入面板 to Bekko / 向量索引面板Help docs, all three languages (heading IDs unchanged except one new
#settings-guide-sync-progress):local-embedding.md: largely rewritten against the current UI. It wrongly said memory vectors sync via Gist (they're stripped on upload), used the old 批量嵌入 entry name and nonexistent buttons, described a sync-pause banner that doesn't exist, and lacked the new download progresssettings-guide.md: task default model sync / fallback rules, v6 upload granularity, abort-on-failure and mid-upload stop, new 同步进度 section, revision history grouping, cleanup panel details, embedding load progress and Workertoolbar-guide.md: 向量索引 entry on desktop / tablet / narrow layouts, local embedding gated by device UA (not window width), 整体进度 in the sync panel, plus other layout correctionsai-models-guide.md: task default model sync rules; explicit local / LAN address ranges that bypass the CORS proxybook-details-memory.md: access time and vectors stay on the device; sync merges on content modification timeREADME.md/README.zh-TW.md/README.en-US.md: the "v0.17" highlight replaced with "v0.18" (latest release only); the Firecrawl fallback moved to quick start; a sync bullet for chapter-group sync and cleanup; release-notes links point to v0.18.0Small i18n fix (
src/i18n/*/embedding-ui.ts,settings-ui.ts):embeddingUi.mobileHintsaid to generate vectors on desktop and read them on mobile, but vectors never sync;settingsUi.embedding.chapterAuto*pointed to a "popup at the top of the book details page", which is now a panel in the side rail / top system barEmbedding sync gate fix (from review): the queue now tracks
syncGateActive(set / cleared only byapplySyncGate) separately fromuserPaused, so no manual or settings-drivenpause()/resume()can release the gate mid-sync, and a user pause survives gate release. Progress exposessyncGated, and the 恢复 buttons in the 向量索引 panel and the memory panel are disabled while it is set. Memory batches now write one item at a time, stop when the gate closes, andupdateMemoryEmbeddingInDBcompares the memory's content / summary with the text the vectors were computed from inside the same IDB write transaction (and the in-memory caches are only updated for entries whose text still matches); items not written are discarded and requeued instead of writing pre-sync vectors onto synced records (chapters already re-check before writing). Six regression tests inembedding-queue.test.ts; the bug predates this release and is listed under 问题修复.Legacy apply fixes (from review):
writeImportedMemory, the stale-memory delete inapplyBookMemories, and the stale model / book deletes inapplyDownloadedAiModels/applyDownloadedNovelsno longer swallow errors, matching the v6 paths, so a failed write or delete during the v1–5 → v6 migration aborts the round instead of uploading a manifest that drops or republishes data; while stale model deletes run, the model store lists both the newly saved and the stale models, so a failed delete lets the rollback remove the new ones and a retry still finds the stale ones. Because remote records may have an empty summary,createMemoryWithIdgained a{ allowEmptyText: true }sync-import option (used only bywriteImportedMemory) so such records import instead of failing the whole migration / restore; normal creation still rejects empty summaries, and content / summary must still be strings — also enforced inupsertMemoryForSyncfor v6 entries. Regression tests insync-data-service.test.tsandmemory-sync-access.test.ts(real service).Per-item fallback for unembedded memories (from review): once the model is ready, memories without a usable vector (stale after the GTE → Bekko switch, or new and not yet embedded) used to be scored with semantic-mode weights and could never pass the 0.3 injection threshold.
memory-scoring.tsnow switches such an item alone to the fallback weights (keyword 0.75 / recency 0.25) when its raw keyword confidence is ≥UNEMBEDDED_FALLBACK_MIN_KEYWORD(0.8); partial matches keep the semantic-mode weights, and items with a valid vector are unchanged, so the semantic-first rule from1b1c07bcstill holds for embedded memories.scoringModeis now per item. Tests updated / added inmemory-scoring.test.ts; release notes,local-embedding.md,book-details-memory.mdandembeddingUi.staleHintdescribe the new behavior.Review follow-ups to the docs: fallback model display on tablet / mobile, 待处理 counts being global, Worker crash / timeout needing a manual 重试, and the embedding-off fallback being keyword + time decay (release notes and both
mobileHintstrings)Notes for reviewers
settings-guide.mdnow says the pre-upload concurrency check makes at most 3 attempts in total (MAX_CONCURRENT_WRITE_RETRIES = 3), correcting the earlier "retries 3 times".ai-models-guide.md, a task whose model hasn't synced yet shows 自动选择 in the desktop dropdown and 未设置 in the tablet / mobile picker; the doc describes that actual behavior.Test plan
bun run type-checkpassedbun run lintpassedbun run quality-checkpassed (i18n check + fallow, no CI-level issues)bunx vitest runpassed (4222 passed, 5 skipped), including help three-language parity and the new regression testsindex.json🤖 Generated with Claude Code