Repository navigation
fix(build): drop patchedDependencies from the packaged Electron package.json - #124
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Verification notes:
Reviewed by glm-5.3 · Input: 39.5K · Output: 8.8K · Cached: 444.8K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.18.0 Release run failed on all four desktop builds after #123 merged:
Quasar copies
package.jsonintodist/electron/UnPackagedand runsbun install --productionthere, but it doesn't copypatches/. Since 7228255 addedpatchedDependenciesfor the Transformers.js 4.3.0 recovery patch, that install can't find the patch file. PR CI never runs the Electron packaging step, so this only showed up in the release build.This adds
electron.extendPackageJsoninquasar.config.tsto deletepatchedDependenciesfrom the packagedpackage.json. The patch only matters for the renderer, and the renderer bundle is built from the rootnode_modules, which is already patched, so the packaged app keeps the fix.Verification
PUPPETEER_SKIP_DOWNLOAD=true bun run build:electron:app(same env as the release job) now gets through the UnPackaged install and finishes with "Build succeeded" (darwin arm64). Without the change it fails with the error above.dist/electron/UnPackaged/package.jsonno longer containspatchedDependencies.assets/transformers.web-*.jscontains the patchedx = x.then(fn, fn)chains and no unpatchedx.then(fn)ones.bun run type-checkandbun run lintpass.After merge
The build jobs check out the
v0.18.0tag, which currently points at the #123 merge commit (without this fix), so re-running the failed jobs would fail again. The tag needs to move to a commit that includes this fix before triggering Release viaworkflow_dispatch. The v0.18.0 release is still a draft, which the workflow is allowed to update.🤖 Generated with Claude Code