Update subscription callback signatures #6005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@mini-1235 this looks fine to apply for me 👍 is there anything needs to be done on your side? (i see this is draft.) |
Contributor
Author
Yes, I still need to update edit: I have pushed it |
fujitatomoya
approved these changes
Dec 7, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm when ros2/rclcpp#2975 is merged
Collaborator
|
@Mergifyio rebase |
Signed-off-by: Maurice <[email protected]>
Signed-off-by: Maurice <[email protected]>
Contributor
✅ Branch has been successfully rebased |
fujitatomoya
force-pushed
the
fix/callback
branch
from
df3a70e to
5d63086
Compare
ahcorde
approved these changes
Dec 8, 2025
ahcorde
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
Signed-off-by: Maurice <[email protected]> (cherry picked from commit bf46139) # Conflicts: # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Broadcaster-Cpp.rst
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
Signed-off-by: Maurice <[email protected]> (cherry picked from commit bf46139)
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
Signed-off-by: Maurice <[email protected]> (cherry picked from commit bf46139) # Conflicts: # source/Tutorials/Advanced/Recording-A-Bag-From-Your-Own-Node-CPP.rst # source/Tutorials/Advanced/Simulators/Webots/Code/MyRobotDriver.cpp # source/Tutorials/Advanced/Simulators/Webots/Code/ObstacleAvoider.cpp # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Broadcaster-Cpp.rst
This was referenced Dec 8, 2025
ahcorde
pushed a commit
that referenced
this pull request
Dec 8, 2025
(cherry picked from commit bf46139) Signed-off-by: Maurice <[email protected]> Co-authored-by: Maurice Alexander Purnawan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to ros2/rclcpp#2975,
ConstSharedPtris preferredDid you use Generative AI?
No
Additional Information