Skip to content

Add info to duration message and time message comments (backport #176) #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 9, 2025

Closes #175

Makes comments for duration messages and time messages more clear, and adds examples for the message types.


This is an automatic backport of pull request #176 done by Mergify.

Signed-off-by: jimmy-mcelwain <[email protected]>
(cherry picked from commit 355006b)

# Conflicts:
#	builtin_interfaces/msg/Duration.msg
#	builtin_interfaces/msg/Time.msg
@mergify mergify bot added the conflicts label May 9, 2025
Copy link
Author

mergify bot commented May 9, 2025

Cherry-pick of 355006b has failed:

On branch mergify/bp/humble/pr-176
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 355006b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   builtin_interfaces/msg/Duration.msg
	both modified:   builtin_interfaces/msg/Time.msg

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented May 9, 2025

Pulls: #179
Gist: https://gist.githubusercontent.com/ahcorde/4270b852b7cbc5cf3c2290f4074e4aa1/raw/6aec71facb6dc6a76f52c0c9675ade1220e89ab9/ros2.repos
BUILD args: --packages-above-and-dependencies rcl_interfaces
TEST args: --packages-above rcl_interfaces
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15944

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 401fd11 into humble May 9, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the mergify/bp/humble/pr-176 branch May 9, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants