Add info to duration message and time message comments #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmy-mcelwain
force-pushed
the
time_msg_comment
branch
2 times, most recently
from
84cf48d to
90a2047
Compare
tfoote
approved these changes
May 6, 2025
There was a problem hiding this comment.
Thanks for the clarifications. LGTM with the suggestions from @christophebedard
fujitatomoya
approved these changes
May 6, 2025
jimmy-mcelwain
force-pushed
the
time_msg_comment
branch
from
90a2047 to
4652ba7
Compare
Signed-off-by: jimmy-mcelwain <[email protected]>
Signed-off-by: jimmy-mcelwain <[email protected]>
jimmy-mcelwain
force-pushed
the
time_msg_comment
branch
from
4652ba7 to
6c9ff00
Compare
|
Pulls: #176
|
christophebedard
approved these changes
May 6, 2025
|
https://github.com/Mergifyio backport kilted jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2025
Signed-off-by: jimmy-mcelwain <[email protected]> (cherry picked from commit 355006b)
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2025
Signed-off-by: jimmy-mcelwain <[email protected]> (cherry picked from commit 355006b)
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2025
Signed-off-by: jimmy-mcelwain <[email protected]> (cherry picked from commit 355006b) # Conflicts: # builtin_interfaces/msg/Duration.msg # builtin_interfaces/msg/Time.msg
ahcorde
pushed a commit
that referenced
this pull request
May 9, 2025
(cherry picked from commit 355006b) Signed-off-by: jimmy-mcelwain <[email protected]> Co-authored-by: Jimmy McElwain <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
May 9, 2025
(cherry picked from commit 355006b) Signed-off-by: jimmy-mcelwain <[email protected]> Co-authored-by: Jimmy McElwain <[email protected]>
ahcorde
added a commit
that referenced
this pull request
May 9, 2025
#179) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Jimmy McElwain <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175
Makes comments for duration messages and time messages more clear, and adds examples for the message types.