Support for React 19 #846

davesnx · 2024-07-16T10:26:03Z

This PR adds some of the new functions on React 19.

useActionState It relies on FormData and depends on melange.dom's PR (Add FormData under melange.dom melange-re/melange#1153, for passing the build and testing other stuff FormData is vendored which we won't publish with FormData here).
Binds to useOptimistic
Change Experimental.use to Experimental.usePromise and add Experimental.useContext
Change act in react-dom/test-utils
Add deprecation in ReactDOMTestUtils
Merged Enable ref as valid prop #862 into it
Merged Replace react dom's testing library with ReactTestingLibrary #859 into it

* 'main' of github.com:/reasonml/reason-react: feat(react): add startTransition (#838) feat(react): add isValidElement (#837)

* 'main' of github.com:/reasonml/reason-react: Remove type callback duplicate

src/FormData.ml

src/ReactDOM.re

src/FormData.ml

src/React.re

* 'main' of github.com:/reasonml/reason-react: fix: type of pipeable stream to allow objects with keys (#854) reason-react-ppx: + lower bound in ocaml add missing entries to changelog Fix multi-child fragment (#852) update compiler version in makefile cmd (#851) Add locations-check test (#844) fix: re-enable failing tests + fix location tests (#850) test: repro #840 (#842) Add CSS Box Alignment Module Level 3 (#847)

Co-authored-by: Javier Chávarri <[email protected]>

anmonteiro · 2024-11-24T05:39:48Z

src/React.re

+
+  /* https://react.dev/reference/react/useOptimistic */
+  [@mel.module "react"]
+  external useOptimistic:


can we @mel.uncurry some of these callbacks?

Since I don't want to push code to this branch directly, done here: #867

anmonteiro · 2024-11-24T05:48:49Z

src/React.re

+  /* https://react.dev/reference/react/useActionState */
+  [@mel.module "react"]
+  external useActionState:
+    (('state, FormData.t) => unit, 'state, ~permalink: bool=?) =>


should we add a unit argument at the end?

Since I don't want to push code to this branch directly, done here: #867

anmonteiro · 2024-11-24T05:53:50Z

@davesnx this is a big PR and there are some big changes. do you have a plan in your head or a link to something you've written about how to land these effectively in reason-react?

more specifically about this PR, how do you want to move forward and what's missing?

davesnx · 2024-11-25T10:57:58Z

I was planning on using the branch "19" as a release candidate branch for all PRs depending on it, test it different repos (ahrefs included) and, if everything is good then do the opam release

* '19' of github.com:/reasonml/reason-react: Update src/React.re Update src/React.re Update src/React.re

* Install melange-testing-library * Install melange-testing-library npm deps * Vendor melange-testing-library * Fix Form__test with RTL * Start migrating Hooks__test * Remove dependency * Remove unused code from Form__test * Add a jest-devtoolsgs * Add a jest-devtools * Migrate Hooks and Form into RTL * Add demo to manually test easily * Use Uncurried for tests * Migrate all React__test * Force install since we are dealing with R19 * Snapshot with lower {} * Remove jest from demo/dune * Add comment on install --force * Bind React.act and React.actAsync * Bind React.act and React.actAsync * Use React.act as async version only * Test react.act and react.actasync * Fix hola test :(

* Install melange-testing-library * Install melange-testing-library npm deps * Vendor melange-testing-library * Fix Form__test with RTL * Start migrating Hooks__test * Remove dependency * Remove unused code from Form__test * Add a jest-devtoolsgs * Add a jest-devtools * Migrate Hooks and Form into RTL * Add demo to manually test easily * Use Uncurried for tests * Migrate all React__test * Force install since we are dealing with R19 * Snapshot with lower {} * Enable ref in ppx * Add jest test for ref * Remove jest from demo/dune * Add comment on install --force * Improve test from checking ref * Bind React.act and React.actAsync * Bind React.act and React.actAsync

* 'main' of github.com:/reasonml/reason-react: Remove raise annotations and fix locations on errors (#863) ppx: support "custom children" in uppercase components without having to wrap in array literal (#823)

* '19' of github.com:/reasonml/reason-react: Enable ref as valid prop (#862) Replace react dom's testing library with ReactTestingLibrary (#859)

* 'main' of github.com:/reasonml/reason-react: test: update snapshot tests to melange v5 (#875) nix: remove nix-filter dependency (#874) chore(nix): remove flake-utils (#873) Get rid of .t from linguist (#868)

* 'main' of github.com:/reasonml/reason-react: Install melange.5.0.0-52 in CI (#882) Update deps (#876) update setup-ocaml to v3 (#878)

davesnx · 2025-02-26T11:12:09Z

This PR is waiting to be merged for a release from react.js @ 19.1.0 with the fix required to work, currently pointed at [email protected]

* 'main' of github.com:/reasonml/reason-react: Documentation updates for 0.16 (#864)

davesnx · 2025-04-03T10:31:11Z

React 19, here we go!

@tatchi

CHANGES: * FEATURE: add color to domProps (@tatchi in reasonml/reason-react#871) * BREAKING: Support for React 19 (@davesnx in reasonml/reason-react#846) * DOCS: Documentation updates for 0.16 (@davesnx in reasonml/reason-react#864) * INFRA: Update deps (@johnhaley81 in reasonml/reason-react#876) * INFRA: update setup-ocaml to v3 (@anmonteiro in reasonml/reason-react#878) * FIX: Remove raise annotations and fix locations on errors (@davesnx reasonml/reason-react#863) * FIX: type of pipeable stream to allow objects with keys (@anmonteiro in reasonml/reason-react#854) * FEATURE: Add `preconnect`, `prefetchDNS`, `preinit`, `preinitModule`, `preload` and `preloadModule` in ReactDOM.Experimental (@r17x in reasonml/reason-react#849) * BREAKING: Make lowerbound be Melange 5.1 (due to Js.FormData.t usage)

davesnx added 3 commits July 16, 2024 11:39

Add useTransition with async support

4d9eeca

Add useTransitionAsync into the interface

39189e0

Add useOptimistic

b869bd3

davesnx mentioned this pull request Jul 16, 2024

Add FormData under melange.dom melange-re/melange#1153

Merged

davesnx added 10 commits July 16, 2024 13:46

Rename use to usePromise and add useContext

e47a0ca

Move useTransitionAsync to Experimental

81942e4

Add formStatus to interface

b823e5c

Leftover from removing useTransitionAsync to Experimental

c4a7fdd

Add action_ and action_Async in ReactDOM props

fd7faa4

Fix reference to function on formStatus

97dd3d3

Merge branch 'main' of github.com:/reasonml/reason-react into 19

e56f547

* 'main' of github.com:/reasonml/reason-react: feat(react): add startTransition (#838) feat(react): add isValidElement (#837)

Embed FormData for now

06b1da6

Add test of Form with useOptimistic

9031415

Merge branch 'main' of github.com:/reasonml/reason-react into 19

52c8144

* 'main' of github.com:/reasonml/reason-react: Remove type callback duplicate

anmonteiro reviewed Aug 10, 2024

View reviewed changes

src/FormData.ml Outdated Show resolved Hide resolved

anmonteiro reviewed Aug 10, 2024

View reviewed changes

src/ReactDOM.re Outdated Show resolved Hide resolved

anmonteiro reviewed Aug 11, 2024

View reviewed changes

src/FormData.ml Outdated Show resolved Hide resolved

anmonteiro reviewed Aug 11, 2024

View reviewed changes

src/React.re Outdated Show resolved Hide resolved

anmonteiro reviewed Aug 11, 2024

View reviewed changes

src/React.re Show resolved Hide resolved

davesnx added 10 commits November 15, 2024 17:08

Embed FormData into ReactDOM

2190bb9

Move formStatus into ReactDOM

e3a97dd

Run formatter

ea1ff9a

Bind React.useActionState instead of ReactDOM.useFormState

a1cbb4f

Remove React.use being 'a => 'b

1ad8321

Revert change on ReactDOM's prop 'action'

447ca53

useAction state published in React.rei

50bde6a

Remove React.use being 'a => 'b

16090ac

Use act from 'react' inseat of react-dom/test-utils

e6fdb2e

davesnx mentioned this pull request Nov 19, 2024

Replace react dom's testing library with ReactTestingLibrary #859

Merged

davesnx and others added 2 commits November 20, 2024 14:19

Update src/React.re

9ce19ea

Co-authored-by: Javier Chávarri <[email protected]>

Update src/React.re

5636b99

Co-authored-by: Javier Chávarri <[email protected]>

anmonteiro reviewed Nov 24, 2024

View reviewed changes

davesnx added 3 commits November 25, 2024 15:27

Add uri comment back on action

cb48b76

Add deprecations on ReactDOMTestUtils

e78adcc

Merge branch '19' of github.com:/reasonml/reason-react into 19

f5f5579

* '19' of github.com:/reasonml/reason-react: Update src/React.re Update src/React.re Update src/React.re

davesnx force-pushed the 19 branch from 5481b9e to f5f5579 Compare November 25, 2024 14:49

davesnx added 2 commits November 25, 2024 18:36

davesnx changed the title ~~Support for React 19 new APIs~~ Support for React 19 Nov 25, 2024

davesnx added 7 commits November 25, 2024 19:28

Merge branch 'main' of github.com:/reasonml/reason-react into 19

ea1f768

* 'main' of github.com:/reasonml/reason-react: Remove raise annotations and fix locations on errors (#863) ppx: support "custom children" in uppercase components without having to wrap in array literal (#823)

Merge branch '19' of github.com:/reasonml/reason-react into 19

05ecc63

* '19' of github.com:/reasonml/reason-react: Enable ref as valid prop (#862) Replace react dom's testing library with ReactTestingLibrary (#859)

Migrate custom childrens test to RTL

e017f0b

Fix role for React__test

ba36dc2

Rollback change on _ppx

52e585a

Merge branch 'main' of github.com:/reasonml/reason-react into 19

4c0e525

* 'main' of github.com:/reasonml/reason-react: test: update snapshot tests to melange v5 (#875) nix: remove nix-filter dependency (#874) chore(nix): remove flake-utils (#873) Get rid of .t from linguist (#868)

Install latest react version with the useState fix

0bc3400

davesnx marked this pull request as ready for review February 24, 2025 17:36

Merge branch 'main' of github.com:/reasonml/reason-react into 19

e9a07d7

* 'main' of github.com:/reasonml/reason-react: Install melange.5.0.0-52 in CI (#882) Update deps (#876) update setup-ocaml to v3 (#878)

davesnx added 2 commits April 3, 2025 12:17

Merge branch 'main' of github.com:/reasonml/reason-react into 19

35f55f2

* 'main' of github.com:/reasonml/reason-react: Documentation updates for 0.16 (#864)

Use [email protected]

7cf0290

davesnx merged commit 5ff3bf7 into main Apr 3, 2025
3 checks passed

davesnx mentioned this pull request Jun 3, 2025

Review most React 19's API #894

Merged

davesnx mentioned this pull request Jul 22, 2025

[new release] reason-react (2 packages) (0.16.0) ocaml/opam-repository#28220

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Support for React 19 #846

Support for React 19 #846

Uh oh!

davesnx commented Jul 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anmonteiro Nov 24, 2024

Uh oh!

davesnx Nov 25, 2024

Uh oh!

anmonteiro Nov 24, 2024

Uh oh!

davesnx Nov 25, 2024

Uh oh!

anmonteiro commented Nov 24, 2024

Uh oh!

davesnx commented Nov 25, 2024

Uh oh!

davesnx commented Feb 26, 2025

Uh oh!

davesnx commented Apr 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Support for React 19 #846

Support for React 19 #846

Uh oh!

Conversation

davesnx commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anmonteiro Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

davesnx Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

anmonteiro Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

davesnx Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

anmonteiro commented Nov 24, 2024

Uh oh!

davesnx commented Nov 25, 2024

Uh oh!

davesnx commented Feb 26, 2025

Uh oh!

davesnx commented Apr 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davesnx commented Jul 16, 2024 •

edited

Loading