Replace react dom's testing library with ReactTestingLibrary #859

davesnx · 2024-11-19T10:39:54Z

Depends on #846

Vendors ReactTestingLibrary (and does some ad-hoc changes) because React 19 deprecates react-dom test utils.
Creates a demo folder to ensure React works manually, loads, etc.
Migrates all jest tests to use RTL
Currently uses React.Uncurried for useState and useReducer waiting for useState uncurry #860 and to have a better solution from [React 19] useState's setter function becomes arity 2 facebook/react#31578

jchavarri

I'm afraid I don't know the reason why switching to another (heavier) testing library is needed.

demo/index.html

test/melange-testing-library/README.md

jchavarri · 2024-11-20T12:04:30Z

test/melange-testing-library/README.md

+This directory contains a vendored version of the melange-testing-library.
+
+The original repository is https://github.com/melange-community/melange-testing-library


The PR description mentions

Vendors ReactTestingLibrary (and does some ad-hoc changes)

are the ad-hoc changes valuable for other users of the bindings? in that case, will they be upstreamed?

Not sure, melange-testing-library contains a few binding designs focused on previous versions of BuckleScript where options aren't translated to undefined, or records aren't objects.

I would keep the changes here and evolve this bindings as a playground for the melange-testing-library

works, but we should upstream as they get better!

jchavarri · 2024-11-20T14:11:42Z

Makefile

 install: ## Update the package dependencies when new deps are added to dune-project
 	@opam install . --deps-only --with-test
-	@npm install
+	@npm install --force


Why was force needed?

Because testinglib and other deps depend on react 18, so npm complains. It is a decent workaround to ensure the installation succeeds

Will write a comment

would we still needed --force if you commit the lockfile from manual install and run npm ci here?

demo/dune

…esting-libraries * '19' of github.com:/reasonml/reason-react: Add deprecations on ReactDOMTestUtils Add uri comment back on action Update src/React.re Update src/React.re Update src/React.re Snapshot with lower {}

…on-react into replace-testing-libraries * 'replace-testing-libraries' of github.com:/reasonml/reason-react: Bind React.act and React.actAsync

…lid-prop * '19' of github.com:/reasonml/reason-react: Replace react dom's testing library with ReactTestingLibrary (#859)

…ises-as-annotations * '19' of github.com:/reasonml/reason-react: Enable ref as valid prop (#862) Replace react dom's testing library with ReactTestingLibrary (#859) Add deprecations on ReactDOMTestUtils Add uri comment back on action Update src/React.re Update src/React.re Update src/React.re Snapshot with lower {}

* '19' of github.com:/reasonml/reason-react: Enable ref as valid prop (#862) Replace react dom's testing library with ReactTestingLibrary (#859)

* Add useTransition with async support * Add useTransitionAsync into the interface * Add useOptimistic * Rename use to usePromise and add useContext * Move useTransitionAsync to Experimental * Add formStatus to interface * Leftover from removing useTransitionAsync to Experimental * Add action_ and action_Async in ReactDOM props * Fix reference to function on formStatus * Embed FormData for now * Add test of Form with useOptimistic * Embed FormData into ReactDOM * Move formStatus into ReactDOM * Run formatter * Bind React.useActionState instead of ReactDOM.useFormState * Remove React.use being 'a => 'b * Revert change on ReactDOM's prop 'action' * useAction state published in React.rei * Remove React.use being 'a => 'b * Use act from 'react' inseat of react-dom/test-utils * Snapshot with lower {} * Update src/React.re Co-authored-by: Javier Chávarri <[email protected]> * Update src/React.re Co-authored-by: Javier Chávarri <[email protected]> * Update src/React.re Co-authored-by: Javier Chávarri <[email protected]> * Add uri comment back on action * Add deprecations on ReactDOMTestUtils * Replace react dom's testing library with ReactTestingLibrary (#859) * Install melange-testing-library * Install melange-testing-library npm deps * Vendor melange-testing-library * Fix Form__test with RTL * Start migrating Hooks__test * Remove dependency * Remove unused code from Form__test * Add a jest-devtoolsgs * Add a jest-devtools * Migrate Hooks and Form into RTL * Add demo to manually test easily * Use Uncurried for tests * Migrate all React__test * Force install since we are dealing with R19 * Snapshot with lower {} * Remove jest from demo/dune * Add comment on install --force * Bind React.act and React.actAsync * Bind React.act and React.actAsync * Use React.act as async version only * Test react.act and react.actasync * Fix hola test :( * Enable ref as valid prop (#862) * Install melange-testing-library * Install melange-testing-library npm deps * Vendor melange-testing-library * Fix Form__test with RTL * Start migrating Hooks__test * Remove dependency * Remove unused code from Form__test * Add a jest-devtoolsgs * Add a jest-devtools * Migrate Hooks and Form into RTL * Add demo to manually test easily * Use Uncurried for tests * Migrate all React__test * Force install since we are dealing with R19 * Snapshot with lower {} * Enable ref in ppx * Add jest test for ref * Remove jest from demo/dune * Add comment on install --force * Improve test from checking ref * Bind React.act and React.actAsync * Bind React.act and React.actAsync * Migrate custom childrens test to RTL * Fix role for React__test * Rollback change on _ppx * Install latest react version with the useState fix * Use [email protected] --------- Co-authored-by: Javier Chávarri <[email protected]>

davesnx added 7 commits November 18, 2024 19:30

Install melange-testing-library

35d588c

Install melange-testing-library npm deps

1cd6a6b

Vendor melange-testing-library

05aa7e1

Fix Form__test with RTL

4434bfd

Start migrating Hooks__test

ab43c4b

Remove dependency

8234b69

Remove unused code from Form__test

49b35e9

davesnx mentioned this pull request Nov 19, 2024

useState uncurry #860

Closed

davesnx added 8 commits November 19, 2024 19:35

Add a jest-devtoolsgs

3ca3ba1

Add a jest-devtools

41ba9c2

Migrate Hooks and Form into RTL

c7998a9

Add demo to manually test easily

5e05f2e

Use Uncurried for tests

f8a08c3

Migrate all React__test

8d156d7

Force install since we are dealing with R19

33ad56a

Snapshot with lower {}

30d82df

davesnx marked this pull request as ready for review November 19, 2024 20:01

davesnx requested a review from jchavarri November 20, 2024 10:55

This was referenced Nov 20, 2024

Enable ref as valid prop #862

Merged

Remove raise annotations and fix locations on errors #863

Merged

jchavarri reviewed Nov 20, 2024

View reviewed changes

jchavarri approved these changes Nov 20, 2024

View reviewed changes

davesnx added 2 commits November 20, 2024 17:13

Remove jest from demo/dune

80e85ae

Add comment on install --force

b39168f

anmonteiro approved these changes Nov 25, 2024

View reviewed changes

davesnx force-pushed the replace-testing-libraries branch from f7d55fe to 7aaef3e Compare November 25, 2024 15:04

davesnx added 3 commits November 25, 2024 16:09

Bind React.act and React.actAsync

5171ac5

Bind React.act and React.actAsync

ad36fbb

Merge branch 'replace-testing-libraries' of github.com:/reasonml/reas…

52addbc

…on-react into replace-testing-libraries * 'replace-testing-libraries' of github.com:/reasonml/reason-react: Bind React.act and React.actAsync

davesnx added 3 commits November 25, 2024 16:46

Use React.act as async version only

2f5ae8d

Test react.act and react.actasync

44faccc

Fix hola test :(

d168359

davesnx merged commit 66cd920 into 19 Nov 25, 2024
3 checks passed

davesnx deleted the replace-testing-libraries branch November 25, 2024 17:36

davesnx added a commit that referenced this pull request Nov 25, 2024

Merge branch '19' of github.com:/reasonml/reason-react into ref-as-va…

2d60883

…lid-prop * '19' of github.com:/reasonml/reason-react: Replace react dom's testing library with ReactTestingLibrary (#859)

davesnx added a commit that referenced this pull request Nov 25, 2024

Merge branch '19' of github.com:/reasonml/reason-react into ref-as-va…

15e0877

…lid-prop * '19' of github.com:/reasonml/reason-react: Replace react dom's testing library with ReactTestingLibrary (#859)

davesnx mentioned this pull request Nov 25, 2024

Support for React 19 #846

Merged

davesnx added a commit that referenced this pull request Nov 25, 2024

Merge branch '19' of github.com:/reasonml/reason-react into 19

05ecc63

* '19' of github.com:/reasonml/reason-react: Enable ref as valid prop (#862) Replace react dom's testing library with ReactTestingLibrary (#859)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace react dom's testing library with ReactTestingLibrary #859

Replace react dom's testing library with ReactTestingLibrary #859

Uh oh!

davesnx commented Nov 19, 2024 •

edited by jchavarri

Loading

Uh oh!

jchavarri left a comment

Uh oh!

Uh oh!

Uh oh!

jchavarri Nov 20, 2024

Uh oh!

davesnx Nov 20, 2024

Uh oh!

anmonteiro Nov 23, 2024

Uh oh!

jchavarri Nov 20, 2024

Uh oh!

davesnx Nov 20, 2024

Uh oh!

davesnx Nov 20, 2024

Uh oh!

anmonteiro Nov 25, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		This directory contains a vendored version of the melange-testing-library.

		The original repository is https://github.com/melange-community/melange-testing-library

Replace react dom's testing library with ReactTestingLibrary #859

Replace react dom's testing library with ReactTestingLibrary #859

Uh oh!

Conversation

davesnx commented Nov 19, 2024 • edited by jchavarri Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jchavarri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jchavarri Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

davesnx Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

anmonteiro Nov 23, 2024

Choose a reason for hiding this comment

Uh oh!

jchavarri Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

davesnx Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

davesnx Nov 20, 2024

Choose a reason for hiding this comment

Uh oh!

anmonteiro Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

davesnx commented Nov 19, 2024 •

edited by jchavarri

Loading