Skip to content

Conversation

@davesnx
Copy link
Contributor

@davesnx davesnx commented Jul 22, 2025

Reason bindings for React.js

CHANGES:

CHANGES:

* FEATURE: add color to domProps (@tatchi in reasonml/reason-react#871)
* BREAKING: Support for React 19 (@davesnx in reasonml/reason-react#846)
* DOCS: Documentation updates for 0.16 (@davesnx in reasonml/reason-react#864)
* INFRA: Update deps (@johnhaley81 in reasonml/reason-react#876)
* INFRA: update setup-ocaml to v3 (@anmonteiro in reasonml/reason-react#878)
* FIX: Remove raise annotations and fix locations on errors (@davesnx reasonml/reason-react#863)
* FIX: type of pipeable stream to allow objects with keys (@anmonteiro in reasonml/reason-react#854)
* FEATURE: Add `preconnect`, `prefetchDNS`, `preinit`, `preinitModule`, `preload` and `preloadModule` in ReactDOM.Experimental (@r17x in reasonml/reason-react#849)
* BREAKING: Make lowerbound be Melange 5.1 (due to Js.FormData.t usage)
@Zeta611
Copy link
Member

Zeta611 commented Jul 24, 2025

There are multiple CI failures with

# File "ppx/reason_react_ppx.ml", lines 573-578, characters 12-13:
# 573 | ............{
# 574 |               pvb_pat = Builder.ppat_var ~loc { txt = key_var_txt; loc };
# 575 |               pvb_expr = mapper#expression ctxt key;
# 576 |               pvb_attributes = [];
# 577 |               pvb_loc = loc;
# 578 |             }.
# Error: Some record fields are undefined: "pvb_constraint"

Is this expected?

@davesnx
Copy link
Contributor Author

davesnx commented Jul 24, 2025

I haven't looked deeply but it seems like ppxlib upper bound for ppxlib should discard 0.36.0

@mseri
Copy link
Member

mseri commented Jul 24, 2025

Looks like the tests of the ppx package need reason-react itself. Should we disable them?

@davesnx
Copy link
Contributor Author

davesnx commented Jul 24, 2025

Yeah, pushing the same build as 0.15 (which effectively remove the test alias). This is safe since we run the CI in our gh actions constantly.

@mseri mseri merged commit f99ed69 into ocaml:master Aug 5, 2025
1 of 2 checks passed
@mseri
Copy link
Member

mseri commented Aug 5, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants