RDK-59955: Bring in Crashupload compiled code by gomathishankar37 · Pull Request #452 · rdkcentral/meta-rdk

gomathishankar37 · 2026-01-08T12:18:12Z

No description provided.

Signed-off-by: P S, Gomathi Shankar <gomathishankar_ps@comcast.com>

Copilot

Pull request overview

This pull request updates the crashupload component to include compiled C code instead of relying solely on shell scripts. The changes update dependency SRCREVs and significantly enhance the crashupload BitBake recipe with compilation support, new dependencies, logging configuration, and systemd integration.

Changes:

Updated SRCREV references for commonutilities and dcmd dependencies to newer commits
Transformed crashupload recipe to build compiled binaries with comprehensive build configuration including CFLAGS, LDFLAGS, and multiple new dependencies (curl, openssl, rfc, telemetry, etc.)
Added syslog-ng and logrotate configuration support for crash upload logging

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
recipes-common/utils/commonutilities_git.bb	Updated SRCREV to newer commit hash
recipes-common/dcmd/dcmd.bb	Updated SRCREV to newer commit hash
recipes-common/crashupload/crashupload_git.bb	Major refactoring to build compiled crashupload binary with new dependencies, build flags, logging configuration, and enhanced systemd integration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T05:38:40Z

recipes-common/crashupload/crashupload_git.bb

 export USE_DBUS = "y"

-LDFLAGS += "-Wl,-O1"
+LDFLAGS:append = "-Wl,-O1"


Missing space before operator. The LDFLAGS append operation is missing the colon separator between append and the equals sign. This should be LDFLAGS:append = "-Wl,-O1" to match the pattern used elsewhere in the file (like line 20 with CFLAGS:append).

Suggested change

LDFLAGS:append = "-Wl,-O1"

LDFLAGS:append = " -Wl,-O1"

Copilot · 2026-01-13T05:38:40Z

recipes-common/crashupload/crashupload_git.bb

+DEPENDS:append:client = " \
+				curl \
+    			openssl \
+				zlib \
+	    		libarchive \
+    			libsyswrapper \
+    			rdk-logger \
+    			commonutilities \
+				rfc \
+				telemetry \
+				"


Inconsistent indentation with tabs used for dependencies. The DEPENDS:append:client section uses tabs for indentation while the rest of the file appears to use spaces. This should be consistent with the indentation style used elsewhere in the file.

Copilot · 2026-01-13T05:38:40Z

recipes-common/crashupload/crashupload_git.bb

        install -d ${D}${base_libdir}/rdk
        install -d ${D}${sysconfdir} ${D}${sysconfdir}/rfcdefaults
-        install -m 0755 ${S}/uploadDumps.sh ${D}${base_libdir}/rdk
+		install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk


Inconsistent indentation with tabs. Line 68 uses tabs while most other lines in the do_install section use spaces. This should be consistent with the surrounding indentation style.

Suggested change

install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk

install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk

Copilot · 2026-01-13T05:38:40Z

recipes-common/crashupload/crashupload_git.bb

                                           minidump-on-bootup-upload.timer \
-"
-RDEPENDS:${PN} += "busybox"
+										"


Inconsistent indentation with tabs. Line 92 uses tabs while the rest of the SYSTEMD_SERVICE assignment uses spaces. This should be consistent with the surrounding indentation style.

Suggested change

"

"

Copilot · 2026-01-13T05:38:41Z

recipes-common/crashupload/crashupload_git.bb

+#-DT2_EVENT_ENABLED \
+#"


The commented-out code on lines 26-27 should either be removed or properly documented with an explanation. Leaving fragmentary commented code without context can be confusing for future maintainers. If T2_EVENT_ENABLED support is intended for future use, add a comment explaining why it's disabled and under what conditions it should be enabled.

Suggested change

#-DT2_EVENT_ENABLED \

#"

Rebase

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T11:18:06Z

recipes-common/crashupload/crashupload_git.bb

+#-DT2_EVENT_ENABLED \
+#"


Commented out code should be removed. Lines 26-27 contain commented out preprocessor definitions that should either be uncommented if needed, or removed to improve code maintainability.

Suggested change

#-DT2_EVENT_ENABLED \

#"

Copilot · 2026-01-13T11:18:06Z

recipes-common/crashupload/crashupload_git.bb


 LICENSE = "Apache-2.0"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e"
+LIC_FILES_CHKSUM = "file://../LICENSE;md5=175792518e4ac015ab6696d16c4f607e"


License file path changed from "file://LICENSE" to "file://../LICENSE". This suggests the LICENSE file is now one directory level up from the working directory. Verify that this path is correct given that S is now set to "${WORKDIR}/git/c_sourcecode" on line 14, which would make the LICENSE file at "${WORKDIR}/git/LICENSE".

Copilot · 2026-01-13T11:18:06Z

recipes-common/crashupload/crashupload_git.bb

+				rfc \
+				telemetry \
+				"
+RDEPENDS:${PN} += "busybox commonutilities telemetry"


RDEPENDS placement creates duplication. Line 63 adds RDEPENDS:${PN} with "busybox commonutilities telemetry", but this duplicates the "busybox" dependency that was previously at the end of the file. The consolidated RDEPENDS should be placed in one location to avoid confusion and potential conflicts.

Suggested change

RDEPENDS:${PN} += "busybox commonutilities telemetry"

RDEPENDS:${PN} += "commonutilities telemetry"

Copilot · 2026-01-13T11:18:07Z

recipes-common/crashupload/crashupload_git.bb

-LDFLAGS += "-Wl,-O1"
+LDFLAGS:append = "-Wl,-O1"
+
+LDFLAGS += "-lrfcapi -ltelemetry_msgsender"


LDFLAGS uses += operator instead of :append. Line 32 uses LDFLAGS:append while line 34 uses LDFLAGS +=. This inconsistency could lead to different behavior. The :append operator is preferred in modern Yocto/BitBake as it defers evaluation and avoids whitespace issues. Consider using LDFLAGS:append consistently.

Suggested change

LDFLAGS += "-lrfcapi -ltelemetry_msgsender"

LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender"

Copilot · 2026-01-13T11:18:07Z

recipes-common/crashupload/crashupload_git.bb

+#HDD_ENABLE
+LOGROTATE_SIZE_crashupload="128000"
+LOGROTATE_ROTATION_crashupload="3"
+#HDD_DISABLE


Commented out code should be removed. Lines 45-50 contain commented out configuration blocks (HDD_ENABLE and HDD_DISABLE) that should either be implemented using proper conditional logic if needed, or removed to improve code maintainability.

Suggested change

#HDD_ENABLE

LOGROTATE_SIZE_crashupload="128000"

LOGROTATE_ROTATION_crashupload="3"

#HDD_DISABLE

LOGROTATE_SIZE_crashupload="128000"

LOGROTATE_ROTATION_crashupload="3"

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T05:28:42Z

recipes-common/crashupload/crashupload_git.bb

+DEPENDS:append:client = " \
+				curl \
+    			openssl \
+				zlib \
+	    		libarchive \
+    			libsyswrapper \
+    			rdk-logger \
+    			commonutilities \
+				rfc \
+				telemetry \
+				"


Inconsistent indentation with tabs and spaces. Lines 53, 55-58 use tabs while lines 54, 56 use spaces. This should be consistent with the rest of the file for maintainability.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T05:56:33Z

recipes-common/crashupload/crashupload_git.bb

 export USE_DBUS = "y"

-LDFLAGS += "-Wl,-O1"
+LDFLAGS:append = "-Wl,-O1"


LDFLAGS:append should include a leading space before the value to prevent concatenation issues. The value should be ' -Wl,-O1' not '-Wl,-O1'.

Suggested change

LDFLAGS:append = "-Wl,-O1"

LDFLAGS:append = " -Wl,-O1"

rebase

RDK-60393: Memcapture as a downloadable app (#465)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T14:32:19Z

recipes-common/crashupload/crashupload_git.bb

+CFLAGS:append = " \
+        		-I=${libdir}/glib-2.0/include \
+        		-I=${includedir}/glib-2.0 \
+        		-DLIBRDKCERTSELECTOR \


The include flags are written as -I=${...} which passes a directory name starting with = to the compiler (e.g., =/usr/lib/...), and is not the normal/valid -I<dir> form. Use -I${libdir}/... (or -I ${libdir}/...) and the same for ${includedir}.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T09:17:55Z

recipes-common/utils/commonutilities_git.bb

 # To have a possibility to override SRC_URI later, we are introducing the following workaround:
-SRCREV = "5c7dfc405cd34da3ab1a1121caf8733ebe35d879"
+SRCREV = "c325e2589e4bd7b78dd5c713b97b23b523746f97"
+
 SRC_URI = "${CMF_GITHUB_ROOT}/common_utilities;module=.;${CMF_GITHUB_SRC_URI_SUFFIX}"


This SRCREV pin is likely being overridden for RDKB builds by conf/distro/include/rdkb.inc, which sets SRCREV:pn-commonutilities (rdkb.inc:199). If this bump is required for the PR’s behavior, please update the distro override as well; otherwise this change may have no effect in the main build configuration.

Copilot · 2026-01-29T09:17:56Z

recipes-common/crashupload/crashupload_git.bb

+# SRCREV = "59925c3570c89347a8e05d852401db923337c495"
+
+# Topic Work - line with develop
+# SRCREV = "75db8702230bf3100ac790fa50e26cc24d8c5c63"
+
+# topic/RDK-59955
+#SRCREV = "4eb66b647e35773da34a61e21c7be98745666dc5"
+
+# Previous Reboot + Ratelimit


The recipe currently carries multiple commented-out SRCREV values and topic notes. This makes it unclear which revision is intended to be built and can lead to accidental pinning to the wrong commit later. Please remove the stale commented SRCREV lines and keep a single authoritative SRCREV (or use a tag/branch override mechanism) with a brief, stable comment explaining why that revision is chosen.

Suggested change

# SRCREV = "59925c3570c89347a8e05d852401db923337c495"

# Topic Work - line with develop

# SRCREV = "75db8702230bf3100ac790fa50e26cc24d8c5c63"

# topic/RDK-59955

#SRCREV = "4eb66b647e35773da34a61e21c7be98745666dc5"

# Previous Reboot + Ratelimit

# Pinned to last known good revision including reboot and rate-limit handling

Copilot · 2026-01-29T09:17:56Z

recipes-common/crashupload/crashupload_git.bb

+LDFLAGS:append = "-Wl,-O1"
+LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig"

-inherit coverity
-inherit systemd
+inherit autotools systemd coverity pkgconfig
+
+DEPENDS:append:client = " \
+						curl \
+    					openssl \
+						zlib \
+	    				libarchive \
+    					libsyswrapper \
+    					rdk-logger \
+    					commonutilities \
+						rdkcertconfig \
+						rfc \
+						telemetry \
+						"


LDFLAGS is unconditionally appending -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig, but the corresponding providers (rfc, telemetry, rdkcertconfig, etc.) are only added to DEPENDS under the :client override. Since this recipe is also built for :broadband (it has do_install:append:broadband()), this creates a hidden build-time dependency and can cause non-client builds to fail at link time. Either scope these LDFLAGS additions to the same override(s) that build the binary, or move the required providers into the unconditional DEPENDS so all variants have the needed sysroot libraries.

Copilot · 2026-01-29T09:17:56Z

recipes-common/crashupload/crashupload_git.bb

+# Previous Reboot + Ratelimit
+SRCREV = "7a2344091ad2a9e19edd0b73b1da01cc49ee4bfe"
+
+S = "${WORKDIR}/git/c_sourcecode"


This SRCREV pin is likely not taking effect for RDKB builds because conf/distro/include/rdkb.inc already sets SRCREV:pn-crashupload (currently at rdkb.inc:198). If the goal of this PR is to bring in the new crashupload compiled code, that distro override also needs to be updated (or removed) so the build actually fetches this revision.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-02T09:53:44Z

recipes-common/crashupload/crashupload_git.bb

+CFLAGS:append = " \
+        		-I=${libdir}/glib-2.0/include \
+        		-I=${includedir}/glib-2.0 \
+        		-DLIBRDKCERTSELECTOR \
+				-DRFC_API_ENABLED \
+        		-DT2_EVENT_ENABLED \
+				-DRDK_LOGGER \
+				-DUSE_EXTENDED_LOGGER_INIT \
+        		"


The compile-time feature macros (-DRFC_API_ENABLED, -DT2_EVENT_ENABLED, -DRDK_LOGGER, etc.) are applied to all builds via CFLAGS:append, but the dependencies that typically provide these headers/libraries are only appended for the client override. If non-client variants don’t have those dependencies staged, this can break compilation or change behavior unintentionally. Consider scoping these macros to :client (or adding the matching dependencies to the base DEPENDS if they are required for all variants).

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T10:00:48Z

recipes-common/crashupload/crashupload_git.bb

+CFLAGS:append = " \
+        		-I=${libdir}/glib-2.0/include \
+        		-I=${includedir}/glib-2.0 \
+        		-DLIBRDKCERTSELECTOR \
+				-DRFC_API_ENABLED \
+        		-DT2_EVENT_ENABLED \
+				-DRDK_LOGGER \
+				-DUSE_EXTENDED_LOGGER_INIT \
+        		"

 export GLIBS = "-lglib-2.0 -lz"
 export USE_DBUS = "y"

-LDFLAGS += "-Wl,-O1"
+LDFLAGS:append = "-Wl,-O1"
+LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig"
+


CFLAGS:append and LDFLAGS:append enable RFC/Telemetry/RdkCertSelector features and link against -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig unconditionally, but the corresponding build dependencies are only added under DEPENDS:append:client. Since the recipe now inherits autotools, the compile/link steps will run for all overrides (including broadband) and can fail due to missing headers/libs in the sysroot. Either (a) move these feature defines and link flags under :client, or (b) add the required DEPENDS for all variants, or (c) explicitly disable the autotools build tasks for non-client variants if they only need the scripts/services.

Copilot · 2026-02-03T10:00:48Z

recipes-common/utils/commonutilities_git.bb

+
+LDFLAGS:append = " -lsafec -lsecure_wrapper"
+


LDFLAGS:append unconditionally adds -lsafec -lsecure_wrapper, but the recipe otherwise treats safec as optional (adds -DSAFEC_DUMMY_API and conditionally appends libs via pkg-config). This unconditional link will break builds when safec is not in DISTRO_FEATURES, and it also introduces a link-time dependency on secure_wrapper without adding the corresponding DEPENDS (typically libsyswrapper). Make linking against safec/secure_wrapper conditional (or rely solely on the existing conditional pkg-config LDFLAGS) and add the correct provider to DEPENDS if secure_wrapper is required.

Suggested change

LDFLAGS:append = " -lsafec -lsecure_wrapper"

DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' libsyswrapper', '', d)}"

LDFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' -lsafec -lsecure_wrapper', '', d)}"

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T10:13:41Z

recipes-common/dcmd/dcmd.bb

-SYSTEMD_SERVICE:${PN} += "dcmd.service"
+inherit breakpad-wrapper
+DEPENDS += "breakpad breakpad-wrapper"
+BREAKPAD_BIN:append = "logupload"


:append does not automatically add whitespace; without a leading space this will concatenate onto any existing value (e.g., "...existing"logupload). Use a leading space in the appended string (or +=) so logupload becomes a separate token.

Suggested change

BREAKPAD_BIN:append = "logupload"

BREAKPAD_BIN:append = " logupload"

Copilot · 2026-02-03T10:13:42Z

recipes-common/dcmd/dcmd.bb

+
+
+# Add any extra packaging if needed
+FILES_${PN} += "${bindir}/logupload"


This uses the older underscore override syntax (FILES_${PN}) while the rest of the recipe uses the newer override style (SYSTEMD_SERVICE:${PN}). For consistency and to avoid override edge-cases on newer BitBake, prefer FILES:${PN} += "${bindir}/logupload".

Suggested change

FILES_${PN} += "${bindir}/logupload"

FILES:${PN} += "${bindir}/logupload"

Copilot · 2026-02-03T10:13:42Z

recipes-common/crashupload/crashupload_git.bb

 export USE_DBUS = "y"

-LDFLAGS += "-Wl,-O1"
+LDFLAGS:append = "-Wl,-O1"


LDFLAGS:append should include a leading space; otherwise the appended value can get glued to the previous token in LDFLAGS, producing an invalid linker argument string. Change to LDFLAGS:append = " -Wl,-O1".

Suggested change

LDFLAGS:append = "-Wl,-O1"

LDFLAGS:append = " -Wl,-O1"

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T14:39:01Z

recipes-common/utils/commonutilities_git.bb

 # or enable this distro feature
 CFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'debug_curl_cdl', ' -DCURL_DEBUG', '', d)}"

+DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"


This bb.utils.contains() call has unescaped double quotes around the fallback value (" "), which will prematurely terminate the BitBake string and break parsing. Use single quotes for the fallback (e.g., '' or ' ') or otherwise escape the inner quotes.

Suggested change

DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"

DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', ' ', d)}"

Copilot · 2026-02-03T14:39:01Z

recipes-common/utils/commonutilities_git.bb

+CFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', '', ' -DSAFEC_DUMMY_API', d)}"
+LDFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' `pkg-config --libs libsafec`', '', d)}"
+
+LDFLAGS:append = " -lsafec -lsecure_wrapper"


LDFLAGS unconditionally appends -lsafec even when DISTRO_FEATURES does not include 'safec' (and the recipe explicitly supports a SAFEC_DUMMY_API path). This can cause link failures on builds without libsafec; make this link conditional (or ensure libsafec is always provided via DEPENDS in all builds).

Suggested change

LDFLAGS:append = " -lsafec -lsecure_wrapper"

LDFLAGS:append = " -lsecure_wrapper"

Bring in Crashupload compiled code

ae0e320

Signed-off-by: P S, Gomathi Shankar <gomathishankar_ps@comcast.com>

gomathishankar37 requested review from a team as code owners January 8, 2026 12:18

gomathishankar37 added 9 commits January 8, 2026 17:53

Update SRCREV for commonutilities

740e715

Update SRCREV to new commit hash

82577fe

Update crashupload_git.bb to include rdkcertconfig

4d375b0

Update SRCREV and install paths in crashupload_git.bb

c930077

Add syslog-ng and logrotate configuration for crashupload

af4b514

Update SRCREV to new commit hash

512372f

Update SRCREV to new commit hash

c11c63b

Update SRCREV to new commit hash

358143d

Update crashupload_git.bb

2dc1758

Copilot AI review requested due to automatic review settings January 13, 2026 05:35

Copilot started reviewing on behalf of gomathishankar37 January 13, 2026 05:36 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

gomathishankar37 added 2 commits January 13, 2026 11:46

Merge pull request #458 from rdkcentral/develop

be7703a

Rebase

Update crashupload_git.bb

4723744

Copilot AI review requested due to automatic review settings January 13, 2026 11:14

Copilot started reviewing on behalf of gomathishankar37 January 13, 2026 11:14 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Update crashupload_git.bb

727b5d3

Copilot AI review requested due to automatic review settings January 14, 2026 05:25

Copilot started reviewing on behalf of gomathishankar37 January 14, 2026 05:25 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

Update crashupload_git.bb

e1a0e4b

Copilot AI review requested due to automatic review settings January 16, 2026 05:54

Copilot started reviewing on behalf of gomathishankar37 January 16, 2026 05:54 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

gomathishankar37 added 2 commits January 16, 2026 11:42

Merge pull request #468 from rdkcentral/develop

856842b

rebase

Merge pull request #473 from rdkcentral/develop

b956270

RDK-60393: Memcapture as a downloadable app (#465)

Update crashupload_git.bb

79767f0

Copilot AI review requested due to automatic review settings January 28, 2026 14:26

Copilot started reviewing on behalf of gomathishankar37 January 28, 2026 14:27 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Update crashupload_git.bb

bfd23e6

Copilot AI review requested due to automatic review settings January 29, 2026 09:12

Copilot started reviewing on behalf of gomathishankar37 January 29, 2026 09:12 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Update crashupload_git.bb

e4ba7e8

Copilot AI review requested due to automatic review settings January 30, 2026 07:44

Copilot started reviewing on behalf of gomathishankar37 January 30, 2026 07:44 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Update crashupload_git.bb

d26e0be

Copilot AI review requested due to automatic review settings February 2, 2026 09:49

Copilot started reviewing on behalf of gomathishankar37 February 2, 2026 09:49 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

Update commonutilities_git.bb

bb8701f

Copilot AI review requested due to automatic review settings February 3, 2026 09:53

Copilot started reviewing on behalf of gomathishankar37 February 3, 2026 09:54 View session

Update dcmd.bb

7a9c092

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Update crashupload_git.bb

08ec59b

Copilot AI review requested due to automatic review settings February 3, 2026 10:03

Copilot started reviewing on behalf of gomathishankar37 February 3, 2026 10:03 View session

Update crashupload_git.bb

96a0361

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Update SRCREV and PV for crashupload

2010b5f

Copilot AI review requested due to automatic review settings February 3, 2026 14:33

Copilot started reviewing on behalf of gomathishankar37 February 3, 2026 14:34 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

	install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk
	install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk

	RDEPENDS:${PN} += "busybox commonutilities telemetry"
	RDEPENDS:${PN} += "commonutilities telemetry"

	LDFLAGS += "-lrfcapi -ltelemetry_msgsender"
	LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender"

-LDFLAGS:append = " -lsafec -lsecure_wrapper"
+DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' libsyswrapper', '', d)}"
+LDFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' -lsafec -lsecure_wrapper', '', d)}"

	BREAKPAD_BIN:append = "logupload"
	BREAKPAD_BIN:append = " logupload"



		# Add any extra packaging if needed
		FILES_${PN} += "${bindir}/logupload"

	FILES_${PN} += "${bindir}/logupload"
	FILES:${PN} += "${bindir}/logupload"

	DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
	DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', ' ', d)}"

	LDFLAGS:append = " -lsafec -lsecure_wrapper"
	LDFLAGS:append = " -lsecure_wrapper"

Conversation

gomathishankar37 commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment