Skip to content

RDK-59955: Bring in Crashupload compiled code #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gomathishankar37 wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

RDK-59955: Bring in Crashupload compiled code #452

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
ae0e320
Bring in Crashupload compiled code
gomathishankar37 Jan 8, 2026
740e715
Update SRCREV for commonutilities
gomathishankar37 Jan 8, 2026
82577fe
Update SRCREV to new commit hash
gomathishankar37 Jan 8, 2026
4d375b0
Update crashupload_git.bb to include rdkcertconfig
gomathishankar37 Jan 9, 2026
c930077
Update SRCREV and install paths in crashupload_git.bb
gomathishankar37 Jan 9, 2026
af4b514
Add syslog-ng and logrotate configuration for crashupload
gomathishankar37 Jan 9, 2026
512372f
Update SRCREV to new commit hash
gomathishankar37 Jan 9, 2026
c11c63b
Update SRCREV to new commit hash
gomathishankar37 Jan 12, 2026
358143d
Update SRCREV to new commit hash
gomathishankar37 Jan 12, 2026
2dc1758
Update crashupload_git.bb
gomathishankar37 Jan 13, 2026
be7703a
Merge pull request #458 from rdkcentral/develop
gomathishankar37 Jan 13, 2026
4723744
Update crashupload_git.bb
gomathishankar37 Jan 13, 2026
727b5d3
Update crashupload_git.bb
gomathishankar37 Jan 14, 2026
e1a0e4b
Update crashupload_git.bb
gomathishankar37 Jan 16, 2026
856842b
Merge pull request #468 from rdkcentral/develop
gomathishankar37 Jan 16, 2026
b956270
Merge pull request #473 from rdkcentral/develop
gomathishankar37 Jan 19, 2026
575baa5
Update crashupload_git.bb
gomathishankar37 Jan 19, 2026
09ca911
Update commonutilities_git.bb
gomathishankar37 Jan 19, 2026
738734b
Update crashupload_git.bb
gomathishankar37 Jan 20, 2026
512ef84
Update crashupload_git.bb
gomathishankar37 Jan 21, 2026
46c2cee
Merge pull request #478 from rdkcentral/develop
gomathishankar37 Jan 21, 2026
c6b54f2
Update crashupload_git.bb
gomathishankar37 Jan 22, 2026
c3d20cf
Merge pull request #480 from rdkcentral/develop
gomathishankar37 Jan 22, 2026
39e09bf
Update crashupload_git.bb
gomathishankar37 Jan 23, 2026
dfe61c7
Update crashupload_git.bb
gomathishankar37 Jan 23, 2026
79767f0
Update crashupload_git.bb
gomathishankar37 Jan 28, 2026
bfd23e6
Update crashupload_git.bb
gomathishankar37 Jan 29, 2026
e4ba7e8
Update crashupload_git.bb
gomathishankar37 Jan 30, 2026
d26e0be
Update crashupload_git.bb
gomathishankar37 Feb 2, 2026
bb8701f
Update commonutilities_git.bb
gomathishankar37 Feb 3, 2026
7a9c092
Update dcmd.bb
gomathishankar37 Feb 3, 2026
08ec59b
Update crashupload_git.bb
gomathishankar37 Feb 3, 2026
96a0361
Update crashupload_git.bb
gomathishankar37 Feb 3, 2026
2010b5f
Update SRCREV and PV for crashupload
gomathishankar37 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 54 additions & 22 deletions recipes-common/crashupload/crashupload_git.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,61 +1,93 @@
SUMMARY = "Crashupload application"
SUMMARY = "Crash Upload Utility for RDK Platforms"
SECTION = "console/utils"

LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e"
LIC_FILES_CHKSUM = "file://../LICENSE;md5=175792518e4ac015ab6696d16c4f607e"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License file path changed from "file://LICENSE" to "file://../LICENSE". This suggests the LICENSE file is now one directory level up from the working directory. Verify that this path is correct given that S is now set to "${WORKDIR}/git/c_sourcecode" on line 14, which would make the LICENSE file at "${WORKDIR}/git/LICENSE".

Copilot uses AI. Check for mistakes.

PV = "1.0.7"
PR = "r0"
PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"

# To have a possibility to override SRC_URI later, we are introducing the following workaround:
CRASHUPLOAD_SRC_URI ?= "${RDK_GENERIC_ROOT_GIT}/crashupload/generic;module=.;protocol=${RDK_GIT_PROTOCOL};branch=${RDK_GIT_BRANCH}"
SRCREV = "8e7e22d2cb988ea58b9ba9d85b8b0812c6dc77d2"
SRC_URI = "${CMF_GITHUB_ROOT}/crashupload;${CMF_GITHUB_SRC_URI_SUFFIX};module=."
S = "${WORKDIR}/git"
SRC_URI = "${CMF_GITHUB_ROOT}/${BPN}.git;nobranch=1;protocol=${CMF_GIT_PROTOCOL}"
# SRCREV = "59925c3570c89347a8e05d852401db923337c495"

# Topic Work - line with develop
# SRCREV = "75db8702230bf3100ac790fa50e26cc24d8c5c63"

# topic/RDK-59955
SRCREV = "4eb66b647e35773da34a61e21c7be98745666dc5"

S = "${WORKDIR}/git/c_sourcecode"

DEPENDS = "glib-2.0 libsyswrapper"

export LINK = "${LD}"

CFLAGS += " \
-I=${libdir}/glib-2.0/include \
-I=${includedir}/glib-2.0 \
"
CFLAGS:append = " \
-I=${libdir}/glib-2.0/include \
-I=${includedir}/glib-2.0 \
-DLIBRDKCERTSELECTOR \
Comment on lines +20 to +23
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The include flags are written as -I=${...} which passes a directory name starting with = to the compiler (e.g., =/usr/lib/...), and is not the normal/valid -I<dir> form. Use -I${libdir}/... (or -I ${libdir}/...) and the same for ${includedir}.

Copilot uses AI. Check for mistakes.
-DRFC_API_ENABLED \
-DT2_EVENT_ENABLED \
-DRDK_LOGGER \
-DUSE_EXTENDED_LOGGER_INIT \
"
Comment on lines +20 to +28
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compile-time feature macros (-DRFC_API_ENABLED, -DT2_EVENT_ENABLED, -DRDK_LOGGER, etc.) are applied to all builds via CFLAGS:append, but the dependencies that typically provide these headers/libraries are only appended for the client override. If non-client variants don’t have those dependencies staged, this can break compilation or change behavior unintentionally. Consider scoping these macros to :client (or adding the matching dependencies to the base DEPENDS if they are required for all variants).

Copilot uses AI. Check for mistakes.

export GLIBS = "-lglib-2.0 -lz"
export USE_DBUS = "y"

LDFLAGS += "-Wl,-O1"
LDFLAGS:append = "-Wl,-O1"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before operator. The LDFLAGS append operation is missing the colon separator between append and the equals sign. This should be LDFLAGS:append = "-Wl,-O1" to match the pattern used elsewhere in the file (like line 20 with CFLAGS:append).

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDFLAGS:append should include a leading space before the value to prevent concatenation issues. The value should be ' -Wl,-O1' not '-Wl,-O1'.

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the flags value. The LDFLAGS:append assignment should include a space at the beginning of the string value to ensure proper concatenation. This should be 'LDFLAGS:append = " -Wl,-O1"' with a leading space in the string.

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after LDFLAGS:append operator. The line should be "LDFLAGS:append = " with a space before the equals sign for consistency with the line above.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDFLAGS:append should include a leading space; otherwise the appended value can get glued to the previous token in LDFLAGS, producing an invalid linker argument string. Change to LDFLAGS:append = " -Wl,-O1".

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.
LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig"
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential build dependency mismatch. The LDFLAGS on line 38 reference libraries (-lrfcapi, -ltelemetry_msgsender, -lRdkCertSelector, -lrdkconfig) that are provided by dependencies only added in DEPENDS:append:client (lines 42-53). If these libraries are only needed for client builds, the LDFLAGS should also be scoped with :client override like 'LDFLAGS:append:client'. Otherwise, builds for non-client configurations may fail due to missing libraries.

Suggested change
LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig"
LDFLAGS:append:client = " -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig"

Copilot uses AI. Check for mistakes.
Comment on lines +33 to +34
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the equals sign. Line 37 has "LDFLAGS:append =" while line 38 has "LDFLAGS:append =". The inconsistency should be fixed - both should follow the same pattern with a space before the equals sign for readability.

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig"
LDFLAGS:append = "-Wl,-O1 -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig"

Copilot uses AI. Check for mistakes.

Comment on lines +20 to +35
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CFLAGS:append and LDFLAGS:append enable RFC/Telemetry/RdkCertSelector features and link against -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig unconditionally, but the corresponding build dependencies are only added under DEPENDS:append:client. Since the recipe now inherits autotools, the compile/link steps will run for all overrides (including broadband) and can fail due to missing headers/libs in the sysroot. Either (a) move these feature defines and link flags under :client, or (b) add the required DEPENDS for all variants, or (c) explicitly disable the autotools build tasks for non-client variants if they only need the scripts/services.

Copilot uses AI. Check for mistakes.
inherit autotools systemd coverity pkgconfig
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'pkgconfig' is added to the inherit line but there's no clear indication in this diff that pkg-config functionality is being utilized. If this is needed for the new dependencies, ensure that it's actually required. Otherwise, this should be removed to avoid unnecessary inheritance.

Suggested change
inherit autotools systemd coverity pkgconfig
inherit autotools systemd coverity

Copilot uses AI. Check for mistakes.

inherit coverity
inherit systemd
DEPENDS:append:client = " \
Comment on lines +34 to +38
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recipe appends extra libraries to LDFLAGS globally, but the corresponding build dependencies are only added under DEPENDS:append:client. This can make non-client builds (e.g., broadband) fail at link time due to missing -dev sysroot content. Either scope these LDFLAGS additions to :client as well, or move the required deps out of the :client override so all builds have the needed libraries.

Copilot uses AI. Check for mistakes.
curl \
Comment on lines +34 to +39
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDFLAGS unconditionally adds -lrfcapi -ltelemetry_msgsender -lRdkCertSelector -lrdkconfig, but the providers for these libraries are only present in DEPENDS:append:client. This will likely break builds for non-client overrides (e.g., broadband) during link. Make the deps and flags consistent by either moving the required recipes into the base DEPENDS or gating the LDFLAGS additions (and related CFLAGS feature defines) with the same override.

Copilot uses AI. Check for mistakes.
openssl \
zlib \
libarchive \
libsyswrapper \
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DEPENDS variable lists 'libsyswrapper' twice: once on line 24 as a base dependency and again on line 49 in the client-specific dependencies. This duplication is unnecessary and should be removed from one location.

Suggested change
libsyswrapper \

Copilot uses AI. Check for mistakes.
rdk-logger \
commonutilities \
rdkcertconfig \
rfc \
telemetry \
"
Comment on lines +39 to +49
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation with mixed tabs and spaces. The DEPENDS:append:client section uses a mix of tabs and spaces for indentation. Please use consistent indentation throughout this block to match the project's style.

Suggested change
curl \
openssl \
zlib \
libarchive \
libsyswrapper \
rdk-logger \
commonutilities \
rdkcertconfig \
rfc \
telemetry \
"
curl \
openssl \
zlib \
libarchive \
libsyswrapper \
rdk-logger \
commonutilities \
rdkcertconfig \
rfc \
telemetry \
"

Copilot uses AI. Check for mistakes.
Comment on lines +38 to +49
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent whitespace formatting. The DEPENDS block uses tabs instead of spaces, which is inconsistent with standard BitBake style conventions. All indentation should use consistent spacing.

Copilot uses AI. Check for mistakes.
Comment on lines +38 to +49
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation with tabs used here. The formatting should be consistent with the rest of the file using spaces.

Copilot uses AI. Check for mistakes.
Comment on lines +39 to +49
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent whitespace: mixing tabs and spaces for indentation in the DEPENDS:append:client block. Lines should use consistent indentation (either all tabs or all spaces). This affects readability and maintainability.

Suggested change
curl \
openssl \
zlib \
libarchive \
libsyswrapper \
rdk-logger \
commonutilities \
rdkcertconfig \
rfc \
telemetry \
"
curl \
openssl \
zlib \
libarchive \
libsyswrapper \
rdk-logger \
commonutilities \
rdkcertconfig \
rfc \
telemetry \
"

Copilot uses AI. Check for mistakes.

do_install() {
install -d ${D}${base_libdir}/rdk
install -d ${D}${sysconfdir} ${D}${sysconfdir}/rfcdefaults
install -m 0755 ${S}/uploadDumps.sh ${D}${base_libdir}/rdk
install -m 0755 ${WORKDIR}/git/uploadDumps.sh ${D}${base_libdir}/rdk
install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk
}

do_install:append:client() {
install -d ${D}${bindir}
install -m 0755 ${B}/src/crashupload ${D}${bindir}/crashupload
}

do_install:append:broadband() {
use_sysv="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'false', 'true', d)}"
$use_sysv || install -d ${D}${systemd_unitdir}/system
$use_sysv || install -m 0644 ${S}/coredump-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${S}/coredump-upload.path ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.path ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/
install -d ${D}${sysconfdir}
install -m 0755 ${S}/uploadDumpsUtils.sh ${D}${base_libdir}/rdk
install -m 0755 ${WORKDIR}/git/uploadDumpsUtils.sh ${D}${base_libdir}/rdk
}

SYSTEMD_SERVICE:${PN}:append:broadband = " coredump-upload.service \
coredump-upload.path \
minidump-on-bootup-upload.service \
minidump-on-bootup-upload.timer \
"
RDEPENDS:${PN} += "busybox"

RDEPENDS:${PN} += "busybox commonutilities"

PACKAGE_BEFORE_PN += "${PN}-conf"

FILES:${PN} += "${base_libdir}/rdk/uploadDumps.sh"
FILES:${PN}:append:client = " ${bindir}/crashupload"
FILES:${PN}:append = " ${base_libdir}/rdk/uploadDumps.sh"
Comment on lines +84 to +85
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FILES variable should use the append operator consistently. Line 88 uses "FILES:${PN}:append:client" while line 89 uses "FILES:${PN}:append". Consider whether line 88 should also follow the pattern or if these are intentionally different scopes.

Copilot uses AI. Check for mistakes.
FILES:${PN}:append = " ${base_libdir}/rdk/runDumpUpload.sh"
FILES:${PN}:append:broadband = " ${base_libdir}/rdk/uploadDumpsUtils.sh"
Comment on lines +85 to 87
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FILES variable assignment pattern is inconsistent. Lines 97-99 use FILES:${PN}:append multiple times to add different files, which will work but is not the typical pattern. Consider combining all file paths into a single assignment or using a more standard pattern with proper spacing for better readability.

Suggested change
FILES:${PN}:append = " ${base_libdir}/rdk/uploadDumps.sh"
FILES:${PN}:append = " ${base_libdir}/rdk/runDumpUpload.sh"
FILES:${PN}:append:broadband = " ${base_libdir}/rdk/uploadDumpsUtils.sh"
FILES:${PN}:append = " ${base_libdir}/rdk/uploadDumps.sh ${base_libdir}/rdk/runDumpUpload.sh"
FILES:${PN}:append:broadband = " ${base_libdir}/rdk/uploadDumpsUtils.sh"

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion recipes-common/dcmd/dcmd.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=2441d6cdabdc0f370be5cd8a746eb647"
# This tells bitbake where to find the files we're providing on the local filesystem
FILESEXTRAPATHS:prepend := "${THISDIR}:"

SRCREV = "03974134e21b316d4053de6574df14b3a423c8d6"
SRCREV = "f63454e4e16dc406e43138d044531b1707462ae5"
SRC_URI = "${CMF_GITHUB_ROOT}/dcm-agent;${CMF_GITHUB_SRC_URI_SUFFIX}"
PV = "1.2.0"
PR = "r0"
Expand Down
3 changes: 2 additions & 1 deletion recipes-common/utils/commonutilities_git.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=24691c8ce48996ecd1102d29eab1216e"

# To have a possibility to override SRC_URI later, we are introducing the following workaround:
SRCREV = "5c7dfc405cd34da3ab1a1121caf8733ebe35d879"
SRCREV = "c325e2589e4bd7b78dd5c713b97b23b523746f97"

Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary blank line added after SRCREV. This extra line serves no functional purpose and should be removed to maintain consistency with the file's formatting style.

Suggested change

Copilot uses AI. Check for mistakes.
SRC_URI = "${CMF_GITHUB_ROOT}/common_utilities;module=.;${CMF_GITHUB_SRC_URI_SUFFIX}"
Comment on lines 5 to 7
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SRCREV pin is likely being overridden for RDKB builds by conf/distro/include/rdkb.inc, which sets SRCREV:pn-commonutilities (rdkb.inc:199). If this bump is required for the PR’s behavior, please update the distro override as well; otherwise this change may have no effect in the main build configuration.

Copilot uses AI. Check for mistakes.

PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"
Expand Down