Skip to content

RDK-59955: Bring in Crashupload compiled code #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gomathishankar37 wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

RDK-59955: Bring in Crashupload compiled code #452

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
ae0e320
Bring in Crashupload compiled code
gomathishankar37 Jan 8, 2026
740e715
Update SRCREV for commonutilities
gomathishankar37 Jan 8, 2026
82577fe
Update SRCREV to new commit hash
gomathishankar37 Jan 8, 2026
4d375b0
Update crashupload_git.bb to include rdkcertconfig
gomathishankar37 Jan 9, 2026
c930077
Update SRCREV and install paths in crashupload_git.bb
gomathishankar37 Jan 9, 2026
af4b514
Add syslog-ng and logrotate configuration for crashupload
gomathishankar37 Jan 9, 2026
512372f
Update SRCREV to new commit hash
gomathishankar37 Jan 9, 2026
c11c63b
Update SRCREV to new commit hash
gomathishankar37 Jan 12, 2026
358143d
Update SRCREV to new commit hash
gomathishankar37 Jan 12, 2026
2dc1758
Update crashupload_git.bb
gomathishankar37 Jan 13, 2026
be7703a
Merge pull request #458 from rdkcentral/develop
gomathishankar37 Jan 13, 2026
4723744
Update crashupload_git.bb
gomathishankar37 Jan 13, 2026
727b5d3
Update crashupload_git.bb
gomathishankar37 Jan 14, 2026
e1a0e4b
Update crashupload_git.bb
gomathishankar37 Jan 16, 2026
856842b
Merge pull request #468 from rdkcentral/develop
gomathishankar37 Jan 16, 2026
b956270
Merge pull request #473 from rdkcentral/develop
gomathishankar37 Jan 19, 2026
575baa5
Update crashupload_git.bb
gomathishankar37 Jan 19, 2026
09ca911
Update commonutilities_git.bb
gomathishankar37 Jan 19, 2026
738734b
Update crashupload_git.bb
gomathishankar37 Jan 20, 2026
512ef84
Update crashupload_git.bb
gomathishankar37 Jan 21, 2026
46c2cee
Merge pull request #478 from rdkcentral/develop
gomathishankar37 Jan 21, 2026
c6b54f2
Update crashupload_git.bb
gomathishankar37 Jan 22, 2026
c3d20cf
Merge pull request #480 from rdkcentral/develop
gomathishankar37 Jan 22, 2026
39e09bf
Update crashupload_git.bb
gomathishankar37 Jan 23, 2026
dfe61c7
Update crashupload_git.bb
gomathishankar37 Jan 23, 2026
79767f0
Update crashupload_git.bb
gomathishankar37 Jan 28, 2026
bfd23e6
Update crashupload_git.bb
gomathishankar37 Jan 29, 2026
e4ba7e8
Update crashupload_git.bb
gomathishankar37 Jan 30, 2026
d26e0be
Update crashupload_git.bb
gomathishankar37 Feb 2, 2026
bb8701f
Update commonutilities_git.bb
gomathishankar37 Feb 3, 2026
7a9c092
Update dcmd.bb
gomathishankar37 Feb 3, 2026
08ec59b
Update crashupload_git.bb
gomathishankar37 Feb 3, 2026
96a0361
Update crashupload_git.bb
gomathishankar37 Feb 3, 2026
2010b5f
Update SRCREV and PV for crashupload
gomathishankar37 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 58 additions & 20 deletions recipes-common/crashupload/crashupload_git.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,61 +1,99 @@
SUMMARY = "Crashupload application"
SUMMARY = "Crash Upload Utility for RDK Platforms"
SECTION = "console/utils"

LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e"
LIC_FILES_CHKSUM = "file://../LICENSE;md5=175792518e4ac015ab6696d16c4f607e"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License file path changed from "file://LICENSE" to "file://../LICENSE". This suggests the LICENSE file is now one directory level up from the working directory. Verify that this path is correct given that S is now set to "${WORKDIR}/git/c_sourcecode" on line 14, which would make the LICENSE file at "${WORKDIR}/git/LICENSE".

Copilot uses AI. Check for mistakes.

PV = "1.0.7"
PR = "r0"
PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"

# To have a possibility to override SRC_URI later, we are introducing the following workaround:
CRASHUPLOAD_SRC_URI ?= "${RDK_GENERIC_ROOT_GIT}/crashupload/generic;module=.;protocol=${RDK_GIT_PROTOCOL};branch=${RDK_GIT_BRANCH}"
SRCREV = "8e7e22d2cb988ea58b9ba9d85b8b0812c6dc77d2"
SRC_URI = "${CMF_GITHUB_ROOT}/crashupload;${CMF_GITHUB_SRC_URI_SUFFIX};module=."
S = "${WORKDIR}/git"
SRC_URI = "${CMF_GITHUB_ROOT}/${BPN}.git;nobranch=1;protocol=${CMF_GIT_PROTOCOL}"
SRCREV = "c95fc157325595e1f8ff6a9221a25cf427db52ad"

S = "${WORKDIR}/git/c_sourcecode"

DEPENDS = "glib-2.0 libsyswrapper"

export LINK = "${LD}"

CFLAGS += " \
CFLAGS:append = " \
-I=${libdir}/glib-2.0/include \
-I=${includedir}/glib-2.0 \
-DLIBRDKCERTSELECTOR \
-DRFC_API_ENABLED \
"
#-DT2_EVENT_ENABLED \
#"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out code on lines 26-27 should either be removed or properly documented with an explanation. Leaving fragmentary commented code without context can be confusing for future maintainers. If T2_EVENT_ENABLED support is intended for future use, add a comment explaining why it's disabled and under what conditions it should be enabled.

Suggested change
#-DT2_EVENT_ENABLED \
#"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code should be removed. Lines 26-27 contain commented out preprocessor definitions that should either be uncommented if needed, or removed to improve code maintainability.

Suggested change
#-DT2_EVENT_ENABLED \
#"

Copilot uses AI. Check for mistakes.

export GLIBS = "-lglib-2.0 -lz"
export USE_DBUS = "y"

LDFLAGS += "-Wl,-O1"
LDFLAGS:append = "-Wl,-O1"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before operator. The LDFLAGS append operation is missing the colon separator between append and the equals sign. This should be LDFLAGS:append = "-Wl,-O1" to match the pattern used elsewhere in the file (like line 20 with CFLAGS:append).

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDFLAGS:append should include a leading space before the value to prevent concatenation issues. The value should be ' -Wl,-O1' not '-Wl,-O1'.

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the flags value. The LDFLAGS:append assignment should include a space at the beginning of the string value to ensure proper concatenation. This should be 'LDFLAGS:append = " -Wl,-O1"' with a leading space in the string.

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after LDFLAGS:append operator. The line should be "LDFLAGS:append = " with a space before the equals sign for consistency with the line above.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDFLAGS:append should include a leading space; otherwise the appended value can get glued to the previous token in LDFLAGS, producing an invalid linker argument string. Change to LDFLAGS:append = " -Wl,-O1".

Suggested change
LDFLAGS:append = "-Wl,-O1"
LDFLAGS:append = " -Wl,-O1"

Copilot uses AI. Check for mistakes.

LDFLAGS += "-lrfcapi -ltelemetry_msgsender"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDFLAGS uses += operator instead of :append. Line 32 uses LDFLAGS:append while line 34 uses LDFLAGS +=. This inconsistency could lead to different behavior. The :append operator is preferred in modern Yocto/BitBake as it defers evaluation and avoids whitespace issues. Consider using LDFLAGS:append consistently.

Suggested change
LDFLAGS += "-lrfcapi -ltelemetry_msgsender"
LDFLAGS:append = " -lrfcapi -ltelemetry_msgsender"

Copilot uses AI. Check for mistakes.

inherit autotools systemd coverity pkgconfig syslog-ng-config-gen logrotate_config

SYSLOG-NG_FILTER = "crashupload"
SYSLOG-NG_SERVICE_crashupload = "minidump-secure-upload.service minidump-upload.service coredump-secure-upload.service coredump-upload.service"
SYSLOG-NG_DESTINATION_crashupload = "core_log.txt"
SYSLOG-NG_LOGRATE_crashupload = "high"

inherit coverity
inherit systemd
LOGROTATE_NAME="crashupload"
LOGROTATE_LOGNAME_crashupload="core_log.txt"
#HDD_ENABLE
LOGROTATE_SIZE_crashupload="128000"
LOGROTATE_ROTATION_crashupload="3"
#HDD_DISABLE
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code should be removed. Lines 45-50 contain commented out configuration blocks (HDD_ENABLE and HDD_DISABLE) that should either be implemented using proper conditional logic if needed, or removed to improve code maintainability.

Suggested change
#HDD_ENABLE
LOGROTATE_SIZE_crashupload="128000"
LOGROTATE_ROTATION_crashupload="3"
#HDD_DISABLE
LOGROTATE_SIZE_crashupload="128000"
LOGROTATE_ROTATION_crashupload="3"

Copilot uses AI. Check for mistakes.
LOGROTATE_SIZE_MEM_crashupload="128000"
LOGROTATE_ROTATION_MEM_crashupload="3"

DEPENDS:append:client = " \
curl \
openssl \
zlib \
libarchive \
libsyswrapper \
rdk-logger \
commonutilities \
rfc \
telemetry \
"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation with tabs used for dependencies. The DEPENDS:append:client section uses tabs for indentation while the rest of the file appears to use spaces. This should be consistent with the indentation style used elsewhere in the file.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation with tabs and spaces. Lines 53, 55-58 use tabs while lines 54, 56 use spaces. This should be consistent with the rest of the file for maintainability.

Copilot uses AI. Check for mistakes.
RDEPENDS:${PN} += "busybox commonutilities telemetry"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDEPENDS placement creates duplication. Line 63 adds RDEPENDS:${PN} with "busybox commonutilities telemetry", but this duplicates the "busybox" dependency that was previously at the end of the file. The consolidated RDEPENDS should be placed in one location to avoid confusion and potential conflicts.

Suggested change
RDEPENDS:${PN} += "busybox commonutilities telemetry"
RDEPENDS:${PN} += "commonutilities telemetry"

Copilot uses AI. Check for mistakes.

do_install() {
install -d ${D}${base_libdir}/rdk
install -d ${D}${sysconfdir} ${D}${sysconfdir}/rfcdefaults
install -m 0755 ${S}/uploadDumps.sh ${D}${base_libdir}/rdk
install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation with tabs. Line 68 uses tabs while most other lines in the do_install section use spaces. This should be consistent with the surrounding indentation style.

Suggested change
install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk
install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk

Copilot uses AI. Check for mistakes.
install -m 0755 ${WORKDIR}/git/uploadDumps.sh ${D}${base_libdir}/rdk
}

do_install:append:client() {
install -d ${D}${bindir}
install -m 0755 ${B}/src/crashupload ${D}${bindir}/crashupload
}

do_install:append:broadband() {
use_sysv="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'false', 'true', d)}"
$use_sysv || install -d ${D}${systemd_unitdir}/system
$use_sysv || install -m 0644 ${S}/coredump-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${S}/coredump-upload.path ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.path ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/
$use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/
install -d ${D}${sysconfdir}
install -m 0755 ${S}/uploadDumpsUtils.sh ${D}${base_libdir}/rdk
install -m 0755 ${WORKDIR}/git/uploadDumpsUtils.sh ${D}${base_libdir}/rdk
}

SYSTEMD_SERVICE:${PN}:append:broadband = " coredump-upload.service \
coredump-upload.path \
minidump-on-bootup-upload.service \
minidump-on-bootup-upload.timer \
"
RDEPENDS:${PN} += "busybox"
"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation with tabs. Line 92 uses tabs while the rest of the SYSTEMD_SERVICE assignment uses spaces. This should be consistent with the surrounding indentation style.

Suggested change
"
"

Copilot uses AI. Check for mistakes.

PACKAGE_BEFORE_PN += "${PN}-conf"

FILES:${PN} += "${base_libdir}/rdk/uploadDumps.sh"
FILES:${PN}:append:client = " ${bindir}/crashupload"
FILES:${PN}:append = " ${base_libdir}/rdk/uploadDumps.sh"
Comment on lines +84 to +85
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FILES variable should use the append operator consistently. Line 88 uses "FILES:${PN}:append:client" while line 89 uses "FILES:${PN}:append". Consider whether line 88 should also follow the pattern or if these are intentionally different scopes.

Copilot uses AI. Check for mistakes.
FILES:${PN}:append = " ${base_libdir}/rdk/runDumpUpload.sh"
FILES:${PN}:append:broadband = " ${base_libdir}/rdk/uploadDumpsUtils.sh"
Comment on lines +85 to 87
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FILES variable assignment pattern is inconsistent. Lines 97-99 use FILES:${PN}:append multiple times to add different files, which will work but is not the typical pattern. Consider combining all file paths into a single assignment or using a more standard pattern with proper spacing for better readability.

Suggested change
FILES:${PN}:append = " ${base_libdir}/rdk/uploadDumps.sh"
FILES:${PN}:append = " ${base_libdir}/rdk/runDumpUpload.sh"
FILES:${PN}:append:broadband = " ${base_libdir}/rdk/uploadDumpsUtils.sh"
FILES:${PN}:append = " ${base_libdir}/rdk/uploadDumps.sh ${base_libdir}/rdk/runDumpUpload.sh"
FILES:${PN}:append:broadband = " ${base_libdir}/rdk/uploadDumpsUtils.sh"

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion recipes-common/dcmd/dcmd.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=2441d6cdabdc0f370be5cd8a746eb647"
# This tells bitbake where to find the files we're providing on the local filesystem
FILESEXTRAPATHS:prepend := "${THISDIR}:"

SRCREV = "03974134e21b316d4053de6574df14b3a423c8d6"
SRCREV = "f63454e4e16dc406e43138d044531b1707462ae5"
SRC_URI = "${CMF_GITHUB_ROOT}/dcm-agent;${CMF_GITHUB_SRC_URI_SUFFIX}"
PV = "1.2.0"
PR = "r0"
Expand Down
2 changes: 1 addition & 1 deletion recipes-common/utils/commonutilities_git.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=24691c8ce48996ecd1102d29eab1216e"

# To have a possibility to override SRC_URI later, we are introducing the following workaround:
SRCREV = "5c7dfc405cd34da3ab1a1121caf8733ebe35d879"
SRCREV = "a7a2c7b707a12754f81c1bad3bb6766e999f12f5"
SRC_URI = "${CMF_GITHUB_ROOT}/common_utilities;module=.;${CMF_GITHUB_SRC_URI_SUFFIX}"

PACKAGE_ARCH = "${MIDDLEWARE_ARCH}"
Expand Down