Skip to content

[ET-VK][Ops] dequantize_per_token.default test setup #11482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: gh/ahmtox/15/base
Choose a base branch
from
Open

[ET-VK][Ops] dequantize_per_token.default test setup #11482

wants to merge 5 commits into from

Conversation

ahmtox
Copy link

@ahmtox ahmtox commented Jun 9, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Creating dequantize_per_token testing framework along with a reference implementation for testing

Differential Revision: D76267037

[ET-VK][Ops] dequantize_per_token.default test setup
308d957 
Creating dequantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/)

[ghstack-poisoned]
@ahmtox ahmtox requested a review from SS-JIA as a code owner June 9, 2025 15:05
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11482

Note: Links to docs will display an error until the docs builds have been completed.

❌ 18 New Failures, 1 Cancelled Job

As of commit e612e25 with merge base cbd3874 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 9, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267037

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"
6626427 
Creating dequantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267037

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"
bd883e5 
Creating dequantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/)

[ghstack-poisoned]
This was referenced Jun 11, 2025
Open
Open
Open
Open
Open
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267037

manuelcandales
manuelcandales reviewed Jun 11, 2025
View reviewed changes
backends/vulkan/test/op_tests/dequantize_test.cpp
ASSERT_TRUE(output_correct);
}

// Test cases for dequantize_per_token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why you don't have int32 and int64 tests here?

Update on "[ET-VK][Ops] dequantize_per_token.default test setup"
0afd268 
Creating dequantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267037

@ahmtox ahmtox added the release notes: vulkan Changes to the Vulkan backend delegate label Jun 11, 2025
Update on "[ET-VK][Ops] dequantize_per_token.default test setup"
e612e25 
Creating dequantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D76267037](https://our.internmc.facebook.com/intern/diff/D76267037/)

[ghstack-poisoned]
@ahmtox ahmtox mentioned this pull request Jun 11, 2025
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales left review comments

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmtox @facebook-github-bot @manuelcandales