Skip to content

[ET-VK][Ops] dequantize_per_tensor.default test setup #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: gh/ahmtox/14/base
Choose a base branch
from
Open

[ET-VK][Ops] dequantize_per_tensor.default test setup #11481

wants to merge 9 commits into from
+385 −0

Conversation

ahmtox
Copy link

@ahmtox ahmtox commented Jun 9, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: D76267054

[ET-VK][Ops] dequantize_per_tensor.default test setup
eadfcdd 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@ahmtox ahmtox requested a review from SS-JIA as a code owner June 9, 2025 15:04
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11481

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 46cadc5 with merge base 4a14fdd (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 9, 2025
Open
Open
Open
Open
Open
Open
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
This was referenced Jun 9, 2025
Open
Open
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
663b539 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
b0e8e26 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
This was referenced Jun 11, 2025
Open
Open
Open
Open
Open
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

manuelcandales
manuelcandales requested changes Jun 11, 2025
View reviewed changes
backends/vulkan/test/op_tests/dequantize_test.cpp
ASSERT_TRUE(output_correct);
}

// Test cases for dequantize_per_tensor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add tests for int32 and int64

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres no real support for int64 in the shader. right now dequantize matches the IO for quantize which include half, float and then uint8, int8, and int32 as common dtypes and to avoid generating excess variants. if int64 is a necessary variant I'll make those changes in a future diff.

there is a diff that adds double support (though really just fp32 underneath)

i will add more tests in this diff.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @ahmtox has pointed out, to reduce binary size Vulkan kind of takes the opposite approach of the portable kernels, which means supporting the minimum dtypes necessary i.e. basically what we would expect to encounter in a "real" model.

Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
d8e0156 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

@ahmtox ahmtox added the release notes: vulkan Changes to the Vulkan backend delegate label Jun 11, 2025
Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
707c6bc 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@ahmtox ahmtox mentioned this pull request Jun 11, 2025
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
e281cd2 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
37f688d 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
07172de 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

Update on "[ET-VK][Ops] dequantize_per_tensor.default test setup"
46cadc5 
Creating dequantize_per_tensor testing framework along with a reference implementation for testing

Differential Revision: [D76267054](https://our.internmc.facebook.com/intern/diff/D76267054/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76267054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmtox @facebook-github-bot @SS-JIA @manuelcandales