Skip to content

[ET-VK][Ops] quantize ops skeleton test framework #11366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: gh/ahmtox/8/base
Choose a base branch
from

Conversation

ahmtox
Copy link

@ahmtox ahmtox commented Jun 4, 2025

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@ahmtox ahmtox requested a review from SS-JIA as a code owner June 4, 2025 18:02
Copy link

pytorch-bot bot commented Jun 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11366

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit e5894a9 with merge base 8cfa858 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

int64_t quant_max,
at::ScalarType dtype) {
auto out = at::empty_like(input, dtype);
// Convert at::ScalarType to executorch::ScalarType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments on #11480

//

// Helper function to get the name of a ScalarType for better error messages
std::string scalar_type_name(c10::ScalarType dtype) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments on #11480

}
}

vkcompute::vkapi::ScalarType from_at_scalartype(c10::ScalarType at_scalartype) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments on #11480

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

@ahmtox ahmtox added the release notes: vulkan Changes to the Vulkan backend delegate label Jun 11, 2025
Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Skeleton framework that is needed to build out the quantize_per_tensor and quantize_per_token operators based on cpu implementation

Differential Revision: [D75959066](https://our.internmc.facebook.com/intern/diff/D75959066/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75959066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants