Develop 1.0.0 #46
Draft
Develop 1.0.0 #46
+451
−269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure package
Merged
suggestions to documentation hierarchy Co-authored-by: Anton Hoyer <[email protected]>
Co-authored-by: Anne Heimes <[email protected]>
V1 api docs
…_file obsolete import test (test_roomacoustics.py) file deleted
v1 test file naming structure
* clarity WIP implemented. Tests in development. * parameters.clarity tests inital * parameters.clarity implemented * tests adjusted for clarity calculation from edc, test for analytic solution added. * clarity calculation adjusted to be solved from edc. * renamed early_time_limit to te (normative) * Docstring example code adjusted to calculation directly from edc * minor linting * obsolete test_data deleted * Update tests/test_parameters_clarity.py test_clarity_preserves_multichannel_shape() Co-authored-by: Anne Heimes <[email protected]> * Update tests/test_parameters_clarity.py test_clarity_from_truth() source comment Co-authored-by: Anne Heimes <[email protected]> * Update tests/test_parameters_clarity.py added ratio test Co-authored-by: Anne Heimes <[email protected]> * Update pyrato/parameters.py simplification to vectored numpy operation Co-authored-by: Anne Heimes <[email protected]> * implemented requested changes * suggested changes implemented, including snake_case linting, non-normalised EDCs, testing, and additional tests * raw docstring because of backslashes * small linting changes * Userwarning stacklevel specified, small fixes * ruff linting, proposed changes * ruff linting, Fomula in Docstring modified * /right added in docstring formula * reference adjusted to rt style, minor style adjustments * references specified * requested changes: no unusual early time limit warning, according test removed, edc cleanup changed * wording in docstring changed * removed unused "warnings" import * Update pyrato/parameters.py line overlength Co-authored-by: Fabian Brinkmann <[email protected]> * Update pyrato/parameters.py line overlength Co-authored-by: Fabian Brinkmann <[email protected]> * Update pyrato/parameters.py line overlength Co-authored-by: Fabian Brinkmann <[email protected]> * Update pyrato/parameters.py Co-authored-by: Marco Berzborn <[email protected]> * Docstring beauty Co-authored-by: Marco Berzborn <[email protected]> * Update pyrato/parameters.py Co-authored-by: Marco Berzborn <[email protected]> * Update pyrato/parameters.py Co-authored-by: Marco Berzborn <[email protected]> * Docstring edits * Docstring edit minor --------- Co-authored-by: Anne Heimes <[email protected]> Co-authored-by: Fabian Brinkmann <[email protected]> Co-authored-by: Marco Berzborn <[email protected]> Co-authored-by: simon.buechner22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch collects all changes intended for v1.0.0
See #42 for the planned changes