Skip to content

Conversation

@ahms5
Copy link
Member

@ahms5 ahms5 commented Jul 31, 2025

for the v1.0.0 we decided to move the functions from toplevel to dedicated modules, and remove som already deprecated function. Thats already done in #46.

Changes proposed in this pull request:

@ahms5 ahms5 requested a review from Copilot July 31, 2025 11:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test files and documentation to reflect module reorganization changes for v1.0.0, specifically moving functions from the main module namespace to organized submodules.

  • Updates function calls to use the new module structure (e.g., ra.parameters. and ra.parametric. prefixes)
  • Removes deprecated test for old function interface
  • Updates documentation examples to reflect the new module organization

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
tests/test_rt.py Updates all calls to reverberation_time_linear_regression to use the new ra.parameters. namespace
tests/test_edc.py Updates calls to energy_decay_curve_analytic to use the new ra.parametric. namespace
tests/test_deprecation_warnings.py Removes test for deprecated reverberation_time_energy_decay_curve function
pyrato/parameters.py Updates docstring example to use the new ra.parameters. namespace

@ahms5 ahms5 added this to the v1.0.0 milestone Jul 31, 2025
@ahms5 ahms5 moved this from Backlog to Require review in Weekly Planning Jul 31, 2025
@ahms5 ahms5 added the bug Something isn't working label Jul 31, 2025
@ahms5 ahms5 self-assigned this Jul 31, 2025
@f-brinkmann
Copy link
Member

I'm not so familiar with pyrato (yet) and passing for this review in the hope that someone else could jump in...

@ahms5
Copy link
Member Author

ahms5 commented Jul 31, 2025

I updated the desription, so make the purpose of the PR more clear, its mainly maintainance stuff for v1.0.0

@github-project-automation github-project-automation bot moved this from Require review to Reviewer Approved in Weekly Planning Aug 8, 2025
Copy link
Member

@mberz mberz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mberz mberz merged commit dd2eb1b into develop_1.0.0 Aug 8, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Weekly Planning Aug 8, 2025
@mberz mberz deleted the v1/fix-tests-examples branch August 8, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants