-
Notifications
You must be signed in to change notification settings - Fork 4
fix tests and examples #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates test files and documentation to reflect module reorganization changes for v1.0.0, specifically moving functions from the main module namespace to organized submodules.
- Updates function calls to use the new module structure (e.g.,
ra.parameters.andra.parametric.prefixes) - Removes deprecated test for old function interface
- Updates documentation examples to reflect the new module organization
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_rt.py | Updates all calls to reverberation_time_linear_regression to use the new ra.parameters. namespace |
| tests/test_edc.py | Updates calls to energy_decay_curve_analytic to use the new ra.parametric. namespace |
| tests/test_deprecation_warnings.py | Removes test for deprecated reverberation_time_energy_decay_curve function |
| pyrato/parameters.py | Updates docstring example to use the new ra.parameters. namespace |
|
I'm not so familiar with pyrato (yet) and passing for this review in the hope that someone else could jump in... |
|
I updated the desription, so make the purpose of the PR more clear, its mainly maintainance stuff for v1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
for the v1.0.0 we decided to move the functions from toplevel to dedicated modules, and remove som already deprecated function. Thats already done in #46.
Changes proposed in this pull request: