Cookiecutter: fix deprecation warnings #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahms5
commented
Feb 11, 2025
| ] | ||
| dependencies = [ | ||
| 'pyfar>=0.5.0', | ||
| 'pyfar>=0.6.0', |
Member
Author
There was a problem hiding this comment.
required for the PyfarDeprecationWarning
ahms5
commented
Feb 11, 2025
ahms5
commented
Feb 11, 2025
mberz
reviewed
Feb 13, 2025
ahms5
commented
Mar 31, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates deprecation warnings to use PyfarDeprecationWarning throughout the codebase and synchronizes related API parameters and dependency versions.
- Replaces DeprecationWarning with PyfarDeprecationWarning for functions, tests, and internal warnings
- Adjusts the parameter name from freq_range to frequency_range in a function call to align with the updated API
- Upgrades the pyfar dependency from version 0.5.0 to 0.6.0
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_dsp.py | Removed several tests related to impulse response start functionality |
| tests/test_deprecation_warnings.py | Updated tests to expect PyfarDeprecationWarning instead of DeprecationWarning |
| pyrato/roomacoustics.py | Switched to PyfarDeprecationWarning for deprecation messages |
| pyrato/edc.py | Minor reformatting adjustments in numerical computations |
| pyrato/dsp.py | Updated warnings to use PyfarDeprecationWarning and renamed a parameter |
| pyproject.toml | Updated pyfar dependency version to >=0.6.0 |
Comments suppressed due to low confidence (2)
tests/test_dsp.py:20
- Several tests for find_impulse_response_start have been removed from this file; please ensure that critical behavior continues to be tested elsewhere.
def test_start_ir_insufficient_snr():
pyrato/dsp.py:332
- The parameter is now passed using 'frequency_range' instead of 'freq_range'. Please double-check that this change correctly matches the updated API of pf.dsp.filter.fractional_octave_bands.
return pf.dsp.filter.fractional_octave_bands(
ahms5
changed the title
f-brinkmann
approved these changes
Apr 13, 2025
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
Member
|
Are the tests failing due to changes in this branch or must something be merged to resolve this? |
Member
Author
|
yes because the changes here are already on develop_v1.0.0 and not fixed yet: |
Member
Author
|
these are hotfixes and potencial hot bugs on main, so this should be done on main |
github-project-automation
bot
moved this from Require review
to Done
in Weekly Planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes all deprecation warnings in #36