-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and isolate js code in files select.html and listeners.html #1291
Conversation
Hi @jywarren, kindly review and consider for merging, many thanks! This PR replaces PRs #1280 by @ayushkumarbhadani, #1274, #1278 & #1275 by @adityagoyal200, #1254 and #1255 by @Leeiaisabelle which were at various levels of completion and required further actions from affected contributors but the common denominator is that none was given final landing. The task of closing out with this PR is as agreed with @7malikk. |
Great work @segun-codes |
Thanks!!! |
…re-listener Update listeners.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Left a couple small requests.
And many thanks to @ayushkumarbhadani, @adityagoyal200, and @Leeiaisabelle for their work on these, which is being combined here! ❤️ 🎉 |
@jywarren, do you want to review and merge now so we call it day on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super. Thanks!!
This PR replaces PRs #1280 by @ayushkumarbhadani, #1274 & #1278 by @adityagoyal200, #1254 and #1255 by @Leeiaisabelle & #1275 by @adityagoyal200.
Fixes #1185 and #1184
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!