Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and isolate js code in files select.html and listeners.html #1291

Merged
merged 12 commits into from
Dec 10, 2022

Conversation

segun-codes
Copy link
Collaborator

@segun-codes segun-codes commented Dec 10, 2022

This PR replaces PRs #1280 by @ayushkumarbhadani, #1274 & #1278 by @adityagoyal200, #1254 and #1255 by @Leeiaisabelle & #1275 by @adityagoyal200.

Fixes #1185 and #1184

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • [] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@segun-codes
Copy link
Collaborator Author

segun-codes commented Dec 10, 2022

Hi @jywarren, kindly review and consider for merging, many thanks!

This PR replaces PRs #1280 by @ayushkumarbhadani, #1274, #1278 & #1275 by @adityagoyal200, #1254 and #1255 by @Leeiaisabelle which were at various levels of completion and required further actions from affected contributors but the common denominator is that none was given final landing.

The task of closing out with this PR is as agreed with @7malikk.

@7malikk
Copy link
Collaborator

7malikk commented Dec 10, 2022

Great work @segun-codes

@segun-codes
Copy link
Collaborator Author

Great work @segun-codes

Thanks!!!

@segun-codes segun-codes changed the title Clean-up and isolate js code in file select.html Clean up and isolate js code in file select.html Dec 10, 2022
@segun-codes segun-codes changed the title Clean up and isolate js code in file select.html Clean up and isolate js code in file select.html and listeners.html Dec 10, 2022
@segun-codes segun-codes changed the title Clean up and isolate js code in file select.html and listeners.html Clean up and isolate js code in files select.html and listeners.html Dec 10, 2022
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Left a couple small requests.

examples/js/select.js Outdated Show resolved Hide resolved
src/edit/iconsets/KeymapperIconSet.js Show resolved Hide resolved
@jywarren
Copy link
Member

And many thanks to @ayushkumarbhadani, @adityagoyal200, and @Leeiaisabelle for their work on these, which is being combined here! ❤️ 🎉

@segun-codes
Copy link
Collaborator Author

@jywarren, do you want to review and merge now so we call it day on this?

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer js code in select.html into separate .js file
3 participants