Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline JS from body [#1185] #1255

Closed
wants to merge 1 commit into from

Conversation

Leeiaisabelle
Copy link

Remove inline JavaScript from body and added <script> in header for external Javascript in ./js/select.js/

Fixes: #1185

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Remove inline JavaScript from body and added <script> in header for external Javascript in ./js/select.js/

Fixes: publiclab#1185
@gitpod-io
Copy link

gitpod-io bot commented Oct 28, 2022

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Leeiaisabelle, the changes in this PR AND #1254 should be in a single PR. Thanks!

@cesswairimu
Copy link
Collaborator

Thanks for attempting this @Leeiaisabelle , it was jointly resolved on #1291, Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer js code in select.html into separate .js file
3 participants