updated listener.html #1275
Closed
updated listener.html #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created a new js file for the removed code
|
|
Hi @adityagoyal200, good effort so far. I just realized you created this PR and PR #1276 to fix issue #1184. Please, merge the two PRs into one and ask @jywarren for a review/merging afterwards. This is also an opportunity for you to use our standard format for PR. For your reference, this PR #1241 uses the format. |
|
Hello @adityagoyal200, still waiting for your feedback so we can give this PR a final landing. |
4 tasks
|
Thanks for attempting this @adityagoyal200 , it has been jointly resolved on #1291, closing this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a new js file for the removed code
Fixes ##1184