Skip to content

feat: implement UI for listing oCIS shares - #4945

Merged
joragua merged 10 commits into
masterfrom
feature/list_ocis_shares
Aug 6, 2026
Merged

feat: implement UI for listing oCIS shares#4945
joragua merged 10 commits into
masterfrom
feature/list_ocis_shares

Conversation

@joragua

@joragua joragua commented Jul 29, 2026 •
edited by jesmrec
Loading

Copy link
Copy Markdown
Member

Related Issues

App: #4876

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

Extra Changes

  • Renamed SpaceMembers to Permissions
  • Renamed SpaceMember to MemberPermission
  • Renamed SpaceMembersResponse to PermissionsResponse
  • Renamed SpaceMemberResponse to MemberPermissionResponse

QA

Test plan: https://github.com/owncloud/QA/blob/android/sharing_ng/Mobile/Android/Executions/Release_4.9/NG%20-%20List%20Shares.md

@joragua joragua self-assigned this Jul 29, 2026
@joragua joragua linked an issue Jul 29, 2026 that may be closed by this pull request
[FEATURE REQUEST] Sharing NG: List shares #4876
Closed
11 tasks done
@joragua
joragua force-pushed the feature/list_ocis_shares branch 5 times, most recently from 5d49a59 to 28ec326 Compare August 4, 2026 14:44
@joragua
joragua marked this pull request as ready for review August 4, 2026 15:29
@joragua
joragua requested a review from a team as a code owner August 4, 2026 15:29
jesmrec
jesmrec requested changes Aug 5, 2026
View reviewed changes

@jesmrec jesmrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments here @joragua. Great job!

Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareFragment.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphSharesAdapter.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareViewModel.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareFragment.kt Outdated
Comment thread ...ncloud/android/data/sharing/shares/datasources/implementation/OCRemoteShareDataSourceTest.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareFragment.kt
Comment thread ...mLibrary/src/main/java/com/owncloud/android/lib/resources/spaces/responses/SpacesResponse.kt
joragua added 8 commits August 5, 2026 12:41
@joragua
feat: implement UI for listing oCIS shares
f75dab9 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
feat: implement methods for oCIS shares listing
6194edf 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
feat: add pull-to-refresh to the oCIS shares list
d40a8b7 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
test: create new tests for OCRemoteShareDataSource and OCShareRepository
8341da7 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
refactor: rename permission models to clarify
75c6caf 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
refactor: rename Ocis prefix to Graph in new share classes
f075a4c 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
chore: add calens file
8a2ef01 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
feat: add release note
97cbde3 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/list_ocis_shares branch from d826082 to 97cbde3 Compare August 5, 2026 10:51
@joragua
fix: validate file data before retrieving shares
6f129f9 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/list_ocis_shares branch from b72ff71 to 6f129f9 Compare August 5, 2026 11:18
@joragua
joragua requested a review from jesmrec August 5, 2026 11:22
jesmrec
jesmrec previously approved these changes Aug 5, 2026
View reviewed changes

@jesmrec jesmrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR Approved 🚀

Moving to QA

@jesmrec

jesmrec commented Aug 5, 2026

Copy link
Copy Markdown
Member

(1)

List of shares is sorted by display name, not by role like in space management:

Screenshot 2026-08-05 at 14 32 19

Xiaomi Redmi 13, Android 15
6f129f9f4

@jesmrec
jesmrec force-pushed the feature/list_ocis_shares branch from 3c49da8 to b590d3f Compare August 5, 2026 13:10
@joragua
joragua force-pushed the feature/list_ocis_shares branch from b590d3f to 3c49da8 Compare August 5, 2026 14:50
@jesmrec

jesmrec commented Aug 5, 2026

Copy link
Copy Markdown
Member

about (1), my explanation was not complete (my fault). The way that sharees are sorted is: first all users and then, all groups. Every of them sorted alphabetically:

Screenshot 2026-08-05 at 16 57 24

@joragua
joragua force-pushed the feature/list_ocis_shares branch from 3c49da8 to 7be9147 Compare August 5, 2026 15:01
@joragua
fix: sort shares by type and display name
2efadba 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/list_ocis_shares branch from 7be9147 to 2efadba Compare August 5, 2026 15:03
@joragua

joragua commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

(1) should be fixed in commit 2efadba

@jesmrec

jesmrec commented Aug 6, 2026

Copy link
Copy Markdown
Member

Approved on my side! moving forward!

@jesmrec
jesmrec self-requested a review August 6, 2026 08:22
@joragua
joragua merged commit 9a75a6c into master Aug 6, 2026
11 checks passed
@joragua
joragua deleted the feature/list_ocis_shares branch August 6, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Sharing NG: List shares

2 participants

@joragua @jesmrec