Skip to content

Commit 28ec326

Browse files
committed
refactor: rename Ocis prefix to Graph in new share classes
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
1 parent 5fe4f3a commit 28ec326

17 files changed

Lines changed: 56 additions & 56 deletions

File tree

‎owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/UseCaseModule.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ import com.owncloud.android.domain.sharing.shares.usecases.CreatePublicShareAsyn
9595
import com.owncloud.android.domain.sharing.shares.usecases.DeleteShareAsyncUseCase
9696
import com.owncloud.android.domain.sharing.shares.usecases.EditPrivateShareAsyncUseCase
9797
import com.owncloud.android.domain.sharing.shares.usecases.EditPublicShareAsyncUseCase
98-
import com.owncloud.android.domain.sharing.shares.usecases.GetOcisSharesAsyncUseCase
98+
import com.owncloud.android.domain.sharing.shares.usecases.GetGraphSharesAsyncUseCase
9999
import com.owncloud.android.domain.sharing.shares.usecases.GetShareAsLiveDataUseCase
100100
import com.owncloud.android.domain.sharing.shares.usecases.GetSharesAsLiveDataUseCase
101101
import com.owncloud.android.domain.sharing.shares.usecases.RefreshSharesFromServerAsyncUseCase
@@ -234,7 +234,7 @@ val useCaseModule = module {
234234
factoryOf(::DeleteShareAsyncUseCase)
235235
factoryOf(::EditPrivateShareAsyncUseCase)
236236
factoryOf(::EditPublicShareAsyncUseCase)
237-
factoryOf(::GetOcisSharesAsyncUseCase)
237+
factoryOf(::GetGraphSharesAsyncUseCase)
238238
factoryOf(::GetShareAsLiveDataUseCase)
239239
factoryOf(::GetShareesAsyncUseCase)
240240
factoryOf(::GetSharesAsLiveDataUseCase)

‎owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/ViewModelModule.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ import com.owncloud.android.presentation.settings.automaticuploads.SettingsVideo
5353
import com.owncloud.android.presentation.settings.logging.SettingsLogsViewModel
5454
import com.owncloud.android.presentation.settings.more.SettingsMoreViewModel
5555
import com.owncloud.android.presentation.settings.security.SettingsSecurityViewModel
56-
import com.owncloud.android.presentation.sharing.OcisShareViewModel
56+
import com.owncloud.android.presentation.sharing.GraphShareViewModel
5757
import com.owncloud.android.presentation.sharing.ShareViewModel
5858
import com.owncloud.android.presentation.spaces.SpacesListViewModel
5959
import com.owncloud.android.presentation.spaces.links.SpaceLinksViewModel
@@ -71,9 +71,9 @@ val viewModelModule = module {
7171
viewModelOf(::DrawerViewModel)
7272
viewModelOf(::FileDetailsViewModel)
7373
viewModelOf(::FileOperationsViewModel)
74+
viewModelOf(::GraphShareViewModel)
7475
viewModelOf(::LogListViewModel)
7576
viewModelOf(::OAuthViewModel)
76-
viewModelOf(::OcisShareViewModel)
7777
viewModelOf(::PatternViewModel)
7878
viewModelOf(::PreviewAudioViewModel)
7979
viewModelOf(::PreviewImageViewModel)

owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/OcisShareFragment.kt renamed to owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareFragment.kt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,18 @@ import org.koin.core.parameter.parametersOf
3939
import timber.log.Timber
4040
import kotlin.apply
4141

42-
class OcisShareFragment : Fragment() {
42+
class GraphShareFragment : Fragment() {
4343
private var _binding: MembersFragmentBinding? = null
4444
private val binding get() = _binding!!
4545

46-
private val ocisShareViewModel by viewModel<OcisShareViewModel> {
46+
private val graphShareViewModel by viewModel<GraphShareViewModel> {
4747
parametersOf(
4848
requireArguments().getString(ARG_ACCOUNT_NAME),
4949
requireArguments().getParcelable<OCFile>(ARG_FILE)
5050
)
5151
}
5252

53-
private lateinit var ocisSharesAdapter: OcisSharesAdapter
53+
private lateinit var graphSharesAdapter: GraphSharesAdapter
5454

5555
private var roles: List<OCRole> = emptyList()
5656

@@ -63,14 +63,14 @@ class OcisShareFragment : Fragment() {
6363
super.onViewCreated(view, savedInstanceState)
6464
binding.membersTitle.text = getString(R.string.share_with_people_title)
6565

66-
ocisSharesAdapter = OcisSharesAdapter()
66+
graphSharesAdapter = GraphSharesAdapter()
6767
binding.membersRecyclerView.apply {
6868
layoutManager = LinearLayoutManager(requireContext())
69-
adapter = ocisSharesAdapter
69+
adapter = graphSharesAdapter
7070
}
7171

7272
binding.swipeRefreshMembers.setOnRefreshListener {
73-
ocisShareViewModel.getOcisShares()
73+
graphShareViewModel.getGraphShares()
7474
}
7575

7676
subscribeToViewModels()
@@ -87,13 +87,13 @@ class OcisShareFragment : Fragment() {
8787
}
8888

8989
private fun observeRoles() {
90-
collectLatestLifecycleFlow(ocisShareViewModel.roles) { event ->
90+
collectLatestLifecycleFlow(graphShareViewModel.roles) { event ->
9191
event?.let {
9292
when (val uiResult = event.peekContent()) {
9393
is UIResult.Success -> {
9494
uiResult.data?.let {
9595
roles = it
96-
ocisShareViewModel.getOcisShares()
96+
graphShareViewModel.getGraphShares()
9797
}
9898
}
9999
is UIResult.Loading -> { }
@@ -107,15 +107,15 @@ class OcisShareFragment : Fragment() {
107107
}
108108

109109
private fun observeShares() {
110-
collectLatestLifecycleFlow(ocisShareViewModel.shares) { event ->
110+
collectLatestLifecycleFlow(graphShareViewModel.shares) { event ->
111111
event?.let {
112112
when (val uiResult = event.peekContent()) {
113113
is UIResult.Success -> {
114114
uiResult.data?.let {
115115
val hasMembers = it.members.isNotEmpty()
116116
binding.membersRecyclerView.isVisible = hasMembers
117117
binding.noSharesMessage.isVisible = !hasMembers
118-
if (hasMembers) ocisSharesAdapter.setShares(it.members, it.roles)
118+
if (hasMembers) graphSharesAdapter.setShares(it.members, it.roles)
119119
binding.swipeRefreshMembers.isRefreshing = false
120120
}
121121
}
@@ -134,12 +134,12 @@ class OcisShareFragment : Fragment() {
134134
private const val ARG_FILE = "FILE"
135135
private const val ARG_ACCOUNT_NAME = "ACCOUNT_NAME"
136136

137-
fun newInstance(file: OCFile, accountName: String): OcisShareFragment {
137+
fun newInstance(file: OCFile, accountName: String): GraphShareFragment {
138138
val args = Bundle().apply {
139139
putParcelable(ARG_FILE, file)
140140
putString(ARG_ACCOUNT_NAME, accountName)
141141
}
142-
return OcisShareFragment().apply {
142+
return GraphShareFragment().apply {
143143
arguments = args
144144
}
145145
}

owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/OcisShareViewModel.kt renamed to owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareViewModel.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import androidx.lifecycle.ViewModel
2424
import com.owncloud.android.domain.files.model.OCFile
2525
import com.owncloud.android.domain.roles.model.OCRole
2626
import com.owncloud.android.domain.roles.usecases.GetRolesAsyncUseCase
27-
import com.owncloud.android.domain.sharing.shares.usecases.GetOcisSharesAsyncUseCase
27+
import com.owncloud.android.domain.sharing.shares.usecases.GetGraphSharesAsyncUseCase
2828
import com.owncloud.android.domain.sharing.shares.model.OCPermissions
2929
import com.owncloud.android.domain.utils.Event
3030
import com.owncloud.android.extensions.ViewModelExt.runUseCaseWithResult
@@ -33,9 +33,9 @@ import com.owncloud.android.providers.CoroutinesDispatcherProvider
3333
import kotlinx.coroutines.flow.MutableStateFlow
3434
import kotlinx.coroutines.flow.StateFlow
3535

36-
class OcisShareViewModel(
36+
class GraphShareViewModel(
3737
private val getRolesAsyncUseCase: GetRolesAsyncUseCase,
38-
private val getOcisSharesAsyncUseCase: GetOcisSharesAsyncUseCase,
38+
private val getGraphSharesAsyncUseCase: GetGraphSharesAsyncUseCase,
3939
private val accountName: String,
4040
private val file: OCFile,
4141
private val coroutineDispatcherProvider: CoroutinesDispatcherProvider,
@@ -56,12 +56,12 @@ class OcisShareViewModel(
5656
)
5757
}
5858

59-
fun getOcisShares() = runUseCaseWithResult(
59+
fun getGraphShares() = runUseCaseWithResult(
6060
coroutineDispatcher = coroutineDispatcherProvider.io,
6161
showLoading = true,
6262
flow = _shares,
63-
useCase = getOcisSharesAsyncUseCase,
64-
useCaseParams = GetOcisSharesAsyncUseCase.Params(
63+
useCase = getGraphSharesAsyncUseCase,
64+
useCaseParams = GetGraphSharesAsyncUseCase.Params(
6565
accountName = accountName,
6666
spaceId = file.spaceId.orEmpty(),
6767
itemId = file.remoteId.orEmpty()

owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/OcisSharesAdapter.kt renamed to owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphSharesAdapter.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,19 @@ import com.owncloud.android.domain.sharing.shares.model.MemberPermission
3333
import com.owncloud.android.utils.DisplayUtils
3434
import com.owncloud.android.utils.PreferenceUtils
3535

36-
class OcisSharesAdapter : RecyclerView.Adapter<OcisSharesAdapter.OcisShareViewHolder>() {
36+
class GraphSharesAdapter : RecyclerView.Adapter<GraphSharesAdapter.GraphShareViewHolder>() {
3737

3838
private var shares: List<MemberPermission> = emptyList()
3939
private var rolesMap: Map<String, String> = emptyMap()
4040

41-
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): OcisShareViewHolder {
41+
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): GraphShareViewHolder {
4242
val inflater = LayoutInflater.from(parent.context)
4343
val view = inflater.inflate(R.layout.member_item, parent, false)
4444
view.filterTouchesWhenObscured = PreferenceUtils.shouldDisallowTouchesWithOtherVisibleWindows(parent.context)
45-
return OcisShareViewHolder(view)
45+
return GraphShareViewHolder(view)
4646
}
4747

48-
override fun onBindViewHolder(holder: OcisShareViewHolder, position: Int) {
48+
override fun onBindViewHolder(holder: GraphShareViewHolder, position: Int) {
4949
val share = shares[position]
5050
val roleNames = share.roles.mapNotNull { rolesMap[it] }
5151

@@ -77,12 +77,12 @@ class OcisSharesAdapter : RecyclerView.Adapter<OcisSharesAdapter.OcisShareViewHo
7777
compareByDescending<MemberPermission> { share -> roles.indexOfFirst { it.id in share.roles } }
7878
.thenBy { it.displayName }
7979
)
80-
val diffResult = DiffUtil.calculateDiff(OcisSharesDiffUtil(this.shares, sortedShares))
80+
val diffResult = DiffUtil.calculateDiff(GraphSharesDiffUtil(this.shares, sortedShares))
8181
this.shares = sortedShares
8282
diffResult.dispatchUpdatesTo(this)
8383
}
8484

85-
class OcisShareViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) {
85+
class GraphShareViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) {
8686
val binding = MemberItemBinding.bind(itemView)
8787
}
8888
}

owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/OcisSharesDiffUtil.kt renamed to owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphSharesDiffUtil.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ package com.owncloud.android.presentation.sharing
2323
import androidx.recyclerview.widget.DiffUtil
2424
import com.owncloud.android.domain.sharing.shares.model.MemberPermission
2525

26-
class OcisSharesDiffUtil(
26+
class GraphSharesDiffUtil(
2727
private val oldList: List<MemberPermission>,
2828
private val newList: List<MemberPermission>,
2929
) : DiffUtil.Callback() {

‎owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/ShareActivity.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class ShareActivity : FileActivity(), ShareFragmentListener {
9595
setupFileHeader(binding)
9696
if (file != null && account != null) {
9797
supportFragmentManager.transaction {
98-
replace(R.id.members_fragment_container, OcisShareFragment.newInstance(file, account!!.name), TAG_SHARE_OCIS_FRAGMENT)
98+
replace(R.id.members_fragment_container, GraphShareFragment.newInstance(file, account!!.name), TAG_GRAPH_SHARE_FRAGMENT)
9999
}
100100
}
101101
}
@@ -371,7 +371,7 @@ class ShareActivity : FileActivity(), ShareFragmentListener {
371371

372372
companion object {
373373
const val TAG_SHARE_FRAGMENT = "SHARE_FRAGMENT"
374-
const val TAG_SHARE_OCIS_FRAGMENT = "SHARE_OCIS_FRAGMENT"
374+
const val TAG_GRAPH_SHARE_FRAGMENT = "GRAPH_SHARE_FRAGMENT"
375375
const val TAG_SEARCH_FRAGMENT = "SEARCH_USER_AND_GROUPS_FRAGMENT"
376376
const val TAG_EDIT_SHARE_FRAGMENT = "EDIT_SHARE_FRAGMENT"
377377
const val TAG_PUBLIC_SHARE_DIALOG_FRAGMENT = "PUBLIC_SHARE_DIALOG_FRAGMENT"

owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/GetRemoteOcisSharesOperation.kt renamed to owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/GetRemoteGraphSharesForFileOperation.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import com.squareup.moshi.Moshi
3232
import timber.log.Timber
3333
import java.net.URL
3434

35-
class GetRemoteOcisSharesOperation(
35+
class GetRemoteGraphSharesForFileOperation(
3636
private val spaceId: String,
3737
private val itemId: String,
3838
) : RemoteOperation<PermissionsResponse>() {
@@ -62,14 +62,14 @@ class GetRemoteOcisSharesOperation(
6262
result = RemoteOperationResult(ResultCode.OK)
6363
result.data = getMethod.getResponseBodyAsString().let { adapter.fromJson(it) }
6464

65-
Timber.d("Get oCIS shares completed and parsed to ${result.data}")
65+
Timber.d("Get graph shares completed and parsed to ${result.data}")
6666
} else {
6767
result = RemoteOperationResult(getMethod)
68-
Timber.e("Failed response while getting oCIS shares; status code: $status, response: $response")
68+
Timber.e("Failed response while getting graph shares; status code: $status, response: $response")
6969
}
7070
} catch (e: Exception) {
7171
result = RemoteOperationResult(e)
72-
Timber.e(e, "Exception while getting oCIS shares")
72+
Timber.e(e, "Exception while getting graph shares")
7373
}
7474
return result
7575
}

‎owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/ShareService.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ interface ShareService : Service {
3939
subfiles: Boolean
4040
): RemoteOperationResult<ShareResponse>
4141

42-
fun getOcisShares(spaceId: String, itemId: String): RemoteOperationResult<PermissionsResponse>
42+
fun getGraphShares(spaceId: String, itemId: String): RemoteOperationResult<PermissionsResponse>
4343

4444
fun insertShare(
4545
remoteFilePath: String,

‎owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/implementation/OCShareService.kt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ package com.owncloud.android.lib.resources.shares.services.implementation
2929
import com.owncloud.android.lib.common.OwnCloudClient
3030
import com.owncloud.android.lib.common.operations.RemoteOperationResult
3131
import com.owncloud.android.lib.resources.shares.CreateRemoteShareOperation
32-
import com.owncloud.android.lib.resources.shares.GetRemoteOcisSharesOperation
32+
import com.owncloud.android.lib.resources.shares.GetRemoteGraphSharesForFileOperation
3333
import com.owncloud.android.lib.resources.shares.GetRemoteSharesForFileOperation
3434
import com.owncloud.android.lib.resources.shares.RemoveRemoteShareOperation
3535
import com.owncloud.android.lib.resources.shares.ShareResponse
@@ -49,8 +49,8 @@ class OCShareService(override val client: OwnCloudClient) : ShareService {
4949
subfiles
5050
).execute(client)
5151

52-
override fun getOcisShares(spaceId: String, itemId: String): RemoteOperationResult<PermissionsResponse> =
53-
GetRemoteOcisSharesOperation(spaceId, itemId).execute(client)
52+
override fun getGraphShares(spaceId: String, itemId: String): RemoteOperationResult<PermissionsResponse> =
53+
GetRemoteGraphSharesForFileOperation(spaceId, itemId).execute(client)
5454

5555
override fun insertShare(
5656
remoteFilePath: String,

0 commit comments

Comments
 (0)