fix: validate file data before retrieving shares

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/extensions/ThrowableExt.kt

@@ -33,6 +33,7 @@ import com.owncloud.android.domain.exceptions.CopyIntoSameFolderException
 import com.owncloud.android.domain.exceptions.FileAlreadyExistsException
 import com.owncloud.android.domain.exceptions.FileNotFoundException
 import com.owncloud.android.domain.exceptions.ForbiddenException
+import com.owncloud.android.domain.exceptions.IncompleteFileDataException
 import com.owncloud.android.domain.exceptions.IncorrectAddressException
 import com.owncloud.android.domain.exceptions.InstanceNotConfiguredException
 import com.owncloud.android.domain.exceptions.InvalidOverwriteException
@@ -84,6 +85,7 @@ fun Throwable.parseError(
             })
             is FileNotFoundException -> resources.getString(R.string.common_not_found)
             is ForbiddenException -> resources.getString(R.string.uploads_view_upload_status_failed_permission_error)
+            is IncompleteFileDataException -> resources.getString(R.string.get_graph_shares_incomplete_data_error)
             is IncorrectAddressException -> resources.getString(R.string.auth_incorrect_address_title)
             is InstanceNotConfiguredException -> resources.getString(R.string.auth_not_configured_title)
             is InvalidOverwriteException -> resources.getString(R.string.file_already_exists)

owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/GraphShareViewModel.kt

@@ -21,6 +21,7 @@
 package com.owncloud.android.presentation.sharing
 
 import androidx.lifecycle.ViewModel
+import com.owncloud.android.domain.exceptions.IncompleteFileDataException
 import com.owncloud.android.domain.files.model.OCFile
 import com.owncloud.android.domain.roles.model.OCRole
 import com.owncloud.android.domain.roles.usecases.GetRolesAsyncUseCase
@@ -32,6 +33,7 @@ import com.owncloud.android.presentation.common.UIResult
 import com.owncloud.android.providers.CoroutinesDispatcherProvider
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.StateFlow
+import kotlinx.coroutines.flow.update
 
 class GraphShareViewModel(
     private val getRolesAsyncUseCase: GetRolesAsyncUseCase,
@@ -56,15 +58,24 @@ class GraphShareViewModel(
         )
     }
 
-    fun getGraphShares() = runUseCaseWithResult(
-        coroutineDispatcher = coroutineDispatcherProvider.io,
-        showLoading = true,
-        flow = _shares,
-        useCase = getGraphSharesAsyncUseCase,
-        useCaseParams = GetGraphSharesAsyncUseCase.Params(
-            accountName = accountName,
-            spaceId = file.spaceId.orEmpty(),
-            itemId = file.remoteId.orEmpty()
+    fun getGraphShares() {
+        val spaceId = file.spaceId
+        val itemId = file.remoteId
+        if (spaceId == null || itemId == null) {
+            _shares.update { Event(UIResult.Error(error = IncompleteFileDataException())) }
+            return
+        }
+
+        runUseCaseWithResult(
+            coroutineDispatcher = coroutineDispatcherProvider.io,
+            showLoading = true,
+            flow = _shares,
+            useCase = getGraphSharesAsyncUseCase,
+            useCaseParams = GetGraphSharesAsyncUseCase.Params(
+                accountName = accountName,
+                spaceId = spaceId,
+                itemId = itemId
+            )
         )
-    )
+    }
 }

owncloudApp/src/main/res/values/strings.xml

@@ -405,6 +405,7 @@
     <string name="error__upload__local_file_not_copied">%1$s could not be copied to %2$s local folder.</string>
 
     <string name="get_shares_error">It was not possible to retrieve the shares from the server</string>
+    <string name="get_graph_shares_incomplete_data_error">Some data could not be retrieved</string>
     <string name="get_sharees_error">It was not possible to retrieve users and groups from the server</string>
     <string name="get_capabilities_error">It was not possible to retrieve the capabilities from the server</string>
     <string name="share_link_file_error">It was not possible to share this file or folder</string>

owncloudDomain/src/main/java/com/owncloud/android/domain/exceptions/IncompleteFileDataException.kt

@@ -0,0 +1,23 @@
+/**
+ * ownCloud Android client application
+ *
+ * @author Jorge Aguado Recio
+ *
+ * Copyright (C) 2026 ownCloud GmbH.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.owncloud.android.domain.exceptions
+
+class IncompleteFileDataException : Exception()