Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44695: Optimize Quay configuration procedure #4413

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jan 14, 2025

Implement the following enhancements:

  • Fix cleanup-composer.sh script to delete containers and volumes without timeout
  • Pull quay container images in background
  • Switched to Quay configuration instructions from https://docs.projectquay.io/deploy_quay.html
    • Start using minimal configuration file
    • Fix quay initialization check to verify HTTP 200
    • Create a microshift superuser with REST API rather than DB operations

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 14, 2025
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-44695, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jogeo, copejon and eslutsky January 14, 2025 07:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@ggiguash ggiguash marked this pull request as draft January 14, 2025 08:07
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
@ggiguash ggiguash changed the title OCPBUGS-44695: Create Quay user with REST API OCPBUGS-44695: Optimize Quay configuration procedure Jan 14, 2025
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-44695, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Implement the following enhancements:

  • Fix cleanup-composer.sh script to delete containers and volumes without timeout
  • Pull quay container images in background
  • Switched to Quay configuration instructions from https://docs.projectquay.io/deploy_quay.html
  • Start using minimal configuration file
  • Fix quay initialization check to verify HTTP 200
  • Create a microshift superuser with REST API rather than DB operations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

ggiguash commented Jan 14, 2025

Subscription server outages 👎
/test e2e-aws-tests-bootc

@ggiguash
Copy link
Contributor Author

Looks like networking errors with registry access and subscription.

/test e2e-aws-tests-bootc e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

Registry pull failures due to an incident at the time

/test e2e-aws-tests-bootc e2e-aws-tests-bootc-arm

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc e2e-aws-tests-bootc-arm

@ggiguash ggiguash marked this pull request as ready for review January 15, 2025 15:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
@openshift-ci openshift-ci bot requested a review from vanhalenar January 15, 2025 15:51
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e39b724 into openshift:main Jan 16, 2025
13 checks passed
@openshift-ci-robot
Copy link

@ggiguash: Jira Issue OCPBUGS-44695: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44695 has been moved to the MODIFIED state.

In response to this:

Implement the following enhancements:

  • Fix cleanup-composer.sh script to delete containers and volumes without timeout
  • Pull quay container images in background
  • Switched to Quay configuration instructions from https://docs.projectquay.io/deploy_quay.html
  • Start using minimal configuration file
  • Fix quay initialization check to verify HTTP 200
  • Create a microshift superuser with REST API rather than DB operations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants